Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277775: Fixup bugids in RemoveDropTargetCrashTest.java - add 4357905 #10967

Closed
wants to merge 1 commit into from

Conversation

Renjithkannath
Copy link
Contributor

@Renjithkannath Renjithkannath commented Nov 3, 2022

Added reference id 4357905 into RemoveDropTargetCrashTest.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277775: Fixup bugids in RemoveDropTargetCrashTest.java - add 4357905

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10967/head:pull/10967
$ git checkout pull/10967

Update a local copy of the PR:
$ git checkout pull/10967
$ git pull https://git.openjdk.org/jdk pull/10967/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10967

View PR using the GUI difftool:
$ git pr show -t 10967

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10967.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 3, 2022

👋 Welcome back Renjithkannath! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8277775: Fixup bugids in RemoveDropTargetCrashTest.java 8277775: Fixup bugids in RemoveDropTargetCrashTest.java - add 4357905 Nov 3, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 3, 2022
@openjdk
Copy link

openjdk bot commented Nov 3, 2022

@Renjithkannath The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 3, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 3, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 3, 2022

⚠️ @Renjithkannath the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8277775-v1
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Nov 3, 2022

@Renjithkannath This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277775: Fixup bugids in RemoveDropTargetCrashTest.java - add 4357905

Reviewed-by: prr, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 3, 2022
@Renjithkannath
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 4, 2022
@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@Renjithkannath
Your change (at version c73fb3e) is now ready to be sponsored by a Committer.

@aivanov-jdk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 4, 2022

Going to push as commit 22347e4.
Since your change was applied there have been 63 commits pushed to the master branch:

  • 1231682: 8296305: Remove unimplemented deoptimized_wrt_marked_nmethods
  • 3378bfe: 8296224: G1: Remove unnecessary update in VM_G1CollectForAllocation
  • 8ee0f7d: 8296231: Fix MEMFLAGS for CHeapBitMaps
  • bd729e6: 8296380: IGV: Shortcut for quick search not working
  • c116ae7: 8295967: RISC-V: Support negVI/negVL instructions for Vector API
  • 9d3b4ef: 8296108: (tz) Update Timezone Data to 2022f
  • 4d1bc1b: 8296285: test/hotspot/jtreg/compiler/intrinsics/TestFloatIsFinite.java fails after JDK-8280378
  • 0349803: 8295319: pending_cards_at_gc_start doesn't include cards in thread buffers
  • 8f6c048: 8296337: CDS SharedArchiveConsistency tests fail after JDK-8296157
  • a8070fb: 8296157: Rename FileMapInfo::space_at() to region_at()
  • ... and 53 more: https://git.openjdk.org/jdk/compare/9b9be88bcaa35c89b6915ff0c251e5a04b10b330...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 4, 2022
@openjdk openjdk bot closed this Nov 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 4, 2022
@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@aivanov-jdk @Renjithkannath Pushed as commit 22347e4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Renjithkannath Renjithkannath deleted the 8277775-v1 branch August 2, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants