Skip to content

JDK-8294536: Update troff form of man page for new --spec-base-url option #10972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Nov 3, 2022

Please review a trivial change to update the open form of the javadoc man page.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294536: Update troff form of man page for new --spec-base-url option

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10972/head:pull/10972
$ git checkout pull/10972

Update a local copy of the PR:
$ git checkout pull/10972
$ git pull https://git.openjdk.org/jdk pull/10972/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10972

View PR using the GUI difftool:
$ git pr show -t 10972

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10972.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 3, 2022

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 3, 2022
@openjdk
Copy link

openjdk bot commented Nov 3, 2022

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label Nov 3, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 3, 2022

Webrevs

Copy link
Member

@hns hns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294536: Update troff form of man page for new --spec-base-url option

Reviewed-by: hannesw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 396 new commits pushed to the master branch:

  • 1231682: 8296305: Remove unimplemented deoptimized_wrt_marked_nmethods
  • 3378bfe: 8296224: G1: Remove unnecessary update in VM_G1CollectForAllocation
  • 8ee0f7d: 8296231: Fix MEMFLAGS for CHeapBitMaps
  • bd729e6: 8296380: IGV: Shortcut for quick search not working
  • c116ae7: 8295967: RISC-V: Support negVI/negVL instructions for Vector API
  • 9d3b4ef: 8296108: (tz) Update Timezone Data to 2022f
  • 4d1bc1b: 8296285: test/hotspot/jtreg/compiler/intrinsics/TestFloatIsFinite.java fails after JDK-8280378
  • 0349803: 8295319: pending_cards_at_gc_start doesn't include cards in thread buffers
  • 8f6c048: 8296337: CDS SharedArchiveConsistency tests fail after JDK-8296157
  • a8070fb: 8296157: Rename FileMapInfo::space_at() to region_at()
  • ... and 386 more: https://git.openjdk.org/jdk/compare/b2e86a620936cc0d65ca884ff2b6644998530354...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 4, 2022
@jonathan-gibbons
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 4, 2022

Going to push as commit 82f9819.
Since your change was applied there have been 402 commits pushed to the master branch:

  • b49bdae: 8294816: C2: Math.min/max vectorization miscompilation
  • c206f28: 8283101: serviceability/jvmti/thread/GetFrameCount/framecnt01/framecnt01.java failing #VirtualThread-Frozen: number of frames expected: 14, got: 9
  • 97c5a64: 8296287: Improve documentation for Types.directSupertypes()
  • f9c7cda: 8294109: JavaDoc search should search whole index
  • 5622b09: 8200337: Generalize see and link tags for user-defined anchors
  • 22347e4: 8277775: Fixup bugids in RemoveDropTargetCrashTest.java - add 4357905
  • 1231682: 8296305: Remove unimplemented deoptimized_wrt_marked_nmethods
  • 3378bfe: 8296224: G1: Remove unnecessary update in VM_G1CollectForAllocation
  • 8ee0f7d: 8296231: Fix MEMFLAGS for CHeapBitMaps
  • bd729e6: 8296380: IGV: Shortcut for quick search not working
  • ... and 392 more: https://git.openjdk.org/jdk/compare/b2e86a620936cc0d65ca884ff2b6644998530354...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 4, 2022
@openjdk openjdk bot closed this Nov 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 4, 2022
@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@jonathan-gibbons Pushed as commit 82f9819.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jonathan-gibbons jonathan-gibbons deleted the 8294536.spec-base-url branch November 4, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants