Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296347: Memory leak from ClassPathDirEntry::_dir #10974

Closed
wants to merge 1 commit into from

Conversation

caoman
Copy link
Contributor

@caoman caoman commented Nov 4, 2022

Hi all,

Could anyone review this fix for this memory leak in ClassPathDirEntry's constructor.

I'm sponsoring colleague Justin King jcking@google.com for this contribution, who found this leak with LeakSanitizer.

-Man


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296347: Memory leak from ClassPathDirEntry::_dir

Reviewers

Contributors

  • Justin King <jcking@google.com>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10974/head:pull/10974
$ git checkout pull/10974

Update a local copy of the PR:
$ git checkout pull/10974
$ git pull https://git.openjdk.org/jdk pull/10974/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10974

View PR using the GUI difftool:
$ git pr show -t 10974

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10974.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 4, 2022

👋 Welcome back manc! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 4, 2022
@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@caoman The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Nov 4, 2022
@caoman
Copy link
Contributor Author

caoman commented Nov 4, 2022

/contributor add Justin King jcking@google.com

@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@caoman
Contributor Justin King <jcking@google.com> successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 4, 2022

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears correct, though I wonder if we ever actually delete these?

@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@caoman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296347: Memory leak from ClassPathDirEntry::_dir

Co-authored-by: Justin King <jcking@google.com>
Reviewed-by: dholmes, ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

  • 671f84b: 8296143: CertAttrSet's set/get mechanism is not type-safe
  • d04d656: 8296433: Encountered null CLD while loading shared lambda proxy class
  • 74f2b16: 8295303: cleanup debug agent's confusing use of EI_GC_FINISH
  • 0ee25de: 8296504: Memory leak in G1PLABAllocator::PLABData
  • dd5d4df: 8295658: G1: Refactor G1SegmentedArray to indicate that it is an allocator
  • cf65605: 8296445: C++ syntax error in jdwpTransport.h
  • 1169dc0: 8296447: RISC-V: Make the operands order of vrsub_vx/vrsub_vi consistent with RVV 1.0 spec
  • 4c80dff: 8296435: RISC-V: Small refactoring for increment/decrement
  • 47d2c7b: 8295376: Improve debug agent virtual thread performance when no debugger is attached
  • 76790ad: 8295673: Deprecate and disable legacy parallel class loading workaround for non-parallel-capable class loaders
  • ... and 35 more: https://git.openjdk.org/jdk/compare/4d1bc1b5add61f443f99f6d0726ebf8e37dc14ab...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 4, 2022
Copy link
Member

@calvinccheung calvinccheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
It passed tiers 1 and 2 testing.

@caoman
Copy link
Contributor Author

caoman commented Nov 8, 2022

Thank you for the review and testing.

@caoman
Copy link
Contributor Author

caoman commented Nov 8, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 8, 2022

Going to push as commit 8146e1a.
Since your change was applied there have been 45 commits pushed to the master branch:

  • 671f84b: 8296143: CertAttrSet's set/get mechanism is not type-safe
  • d04d656: 8296433: Encountered null CLD while loading shared lambda proxy class
  • 74f2b16: 8295303: cleanup debug agent's confusing use of EI_GC_FINISH
  • 0ee25de: 8296504: Memory leak in G1PLABAllocator::PLABData
  • dd5d4df: 8295658: G1: Refactor G1SegmentedArray to indicate that it is an allocator
  • cf65605: 8296445: C++ syntax error in jdwpTransport.h
  • 1169dc0: 8296447: RISC-V: Make the operands order of vrsub_vx/vrsub_vi consistent with RVV 1.0 spec
  • 4c80dff: 8296435: RISC-V: Small refactoring for increment/decrement
  • 47d2c7b: 8295376: Improve debug agent virtual thread performance when no debugger is attached
  • 76790ad: 8295673: Deprecate and disable legacy parallel class loading workaround for non-parallel-capable class loaders
  • ... and 35 more: https://git.openjdk.org/jdk/compare/4d1bc1b5add61f443f99f6d0726ebf8e37dc14ab...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 8, 2022
@openjdk openjdk bot closed this Nov 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 8, 2022
@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@caoman Pushed as commit 8146e1a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@caoman caoman deleted the JDK-8296347 branch November 15, 2022 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
4 participants