Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296349: [aarch64] Avoid slicing Address::extend #10976

Closed
wants to merge 2 commits into from

Conversation

kimbarrett
Copy link

@kimbarrett kimbarrett commented Nov 4, 2022

Please review this change around Address::extend. The 4 derived classes are
replaced by static functions of the same name as the former class. These
functions return an extend object initialized with the same values as were
used by the corresponding derived class constructor.

Testing: mach5 tier1-3


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10976/head:pull/10976
$ git checkout pull/10976

Update a local copy of the PR:
$ git checkout pull/10976
$ git pull https://git.openjdk.org/jdk pull/10976/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10976

View PR using the GUI difftool:
$ git pr show -t 10976

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10976.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 4, 2022

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 4, 2022
@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Nov 4, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 4, 2022

Webrevs

Copy link
Contributor

@theRealAph theRealAph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. That's a nice simplification, thanks.

@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296349: [aarch64] Avoid slicing Address::extend

Reviewed-by: aph, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 4, 2022
@kimbarrett
Copy link
Author

Anyone else?

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too.

@kimbarrett
Copy link
Author

Thanks @theRealAph and @TobiHartmann for reviews.

@kimbarrett
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 11, 2022

Going to push as commit 12e76cb.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 11, 2022
@openjdk openjdk bot closed this Nov 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 11, 2022
@openjdk
Copy link

openjdk bot commented Nov 11, 2022

@kimbarrett Pushed as commit 12e76cb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kimbarrett kimbarrett deleted the flatten-extend branch November 11, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants