8285635: javax/swing/JRootPane/DefaultButtonTest.java failed with Default Button not pressed for L&F: com.sun.java.swing.plaf.motif.MotifLookAndFeel

[prsadhuk]

Test sometimes fail for Motif L&F only which might require some code change in Motif code but since Motif is already deprecated and obsolete, it seems prudent to skip Motif L&F in the test.
Several iterations of the modified test pass in all platforms.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8285635: javax/swing/JRootPane/DefaultButtonTest.java failed with Default Button not pressed for L&F: com.sun.java.swing.plaf.motif.MotifLookAndFeel

Reviewers

• Tejesh R (@TejeshR13 - Committer)
• Jayathirth D V (@jayathirthrao - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10978/head:pull/10978
$ git checkout pull/10978

Update a local copy of the PR:
$ git checkout pull/10978
$ git pull https://git.openjdk.org/jdk pull/10978/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10978

View PR using the GUI difftool:
$ git pr show -t 10978

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10978.diff

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c8fe6929)

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285635: javax/swing/JRootPane/DefaultButtonTest.java failed with Default Button not pressed for L&F: com.sun.java.swing.plaf.motif.MotifLookAndFeel

Reviewed-by: tr, jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 408 new commits pushed to the master branch:

• 0981bfb: 8296156: [macos] Resize DMG windows and background to fit additional DMG contents
• 93fed9b: 8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null
• d6e2d0d: 8296611: Problemlist several sun/security tests until JDK-8295343 is resolved
• 102b2b3: 8292033: Move jdk.X509Certificate event logic to JCA layer
• 1b94ae1: 8296139: Make GrowableBitMap the base class of all implementations
• cc8bf95: 8296718: Refactor bootstrap Test Common Functionalities to test/lib/Utils
• 17e3412: 8296615: use of undeclared identifier 'IPV6_DONTFRAG'
• a5d838c: 8296591: Signature benchmark
• fa8a866: 8296675: Exclude linux-aarch64 in NSS tests
• d4376f8: 8296406: ChainingConstructors jtreg test reduce code duplication
• ... and 398 more: https://git.openjdk.org/jdk/compare/7a194d31a3f2f78211f035f4591845bf2b465aec...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[prsadhuk]

/integrate

[openjdk]

Going to push as commit 79c0092.
Since your change was applied there have been 408 commits pushed to the master branch:

• 0981bfb: 8296156: [macos] Resize DMG windows and background to fit additional DMG contents
• 93fed9b: 8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null
• d6e2d0d: 8296611: Problemlist several sun/security tests until JDK-8295343 is resolved
• 102b2b3: 8292033: Move jdk.X509Certificate event logic to JCA layer
• 1b94ae1: 8296139: Make GrowableBitMap the base class of all implementations
• cc8bf95: 8296718: Refactor bootstrap Test Common Functionalities to test/lib/Utils
• 17e3412: 8296615: use of undeclared identifier 'IPV6_DONTFRAG'
• a5d838c: 8296591: Signature benchmark
• fa8a866: 8296675: Exclude linux-aarch64 in NSS tests
• d4376f8: 8296406: ChainingConstructors jtreg test reduce code duplication
• ... and 398 more: https://git.openjdk.org/jdk/compare/7a194d31a3f2f78211f035f4591845bf2b465aec...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prsadhuk Pushed as commit 79c0092.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.