Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296405: java/util/concurrent/forkjoin/AsyncShutdownNow.java is too slow #10986

Closed
wants to merge 3 commits into from

Conversation

AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Nov 4, 2022

java/util/concurrent/forkjoin/AsyncShutdownNow.java takes ~40s as each test uses a delay of 5s before it invokes shutdownNow. The test will run in <1s if changed to poll the thread state and invoke shutdownNow when the thread waits.

The update temporarily disables testInvokeAny because of a suspected issue doing shutdown at around the same that worker threads are spinning up. It duplicates more frequently (on Windows at least) with the updated test. JDK-8286352 and JDK-8288899 are two bugs on this issue. Doug Lea is looking into the issue. The test can be re-enabled when that issue is resolved.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296405: java/util/concurrent/forkjoin/AsyncShutdownNow.java is too slow

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10986/head:pull/10986
$ git checkout pull/10986

Update a local copy of the PR:
$ git checkout pull/10986
$ git pull https://git.openjdk.org/jdk pull/10986/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10986

View PR using the GUI difftool:
$ git pr show -t 10986

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10986.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 4, 2022

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@AlanBateman The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 4, 2022
@AlanBateman AlanBateman marked this pull request as ready for review November 14, 2022 08:58
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 14, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 14, 2022

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

Unexpected exceptions could happen in onWait and could mean the action never gets run or the action itself fails. That exception isn't propagated back, but I believe that's fine in the case of these tests because these tests run a task which sleeps for a day. So, if the (shutdownNow) action doesn't get run for whatever reason, these tests will fail with a jtreg test timeout and will have the stacktrace printed on System.err from the implementation of the onWait.

}
}

/**
* Test shutdownNow with thread blocked in invokeAny.
*/
@Test(dataProvider = "executors")
@Test(dataProvider = "executors", enabled = false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we file a JBS to re-enable this so that we don't forget?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we file a JBS to re-enable this so that we don't forget?

I'll add a note to JDK-8286352 or JDK-8288899, depending on which one is used.

@openjdk
Copy link

openjdk bot commented Nov 14, 2022

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296405: java/util/concurrent/forkjoin/AsyncShutdownNow.java is too slow

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 68301cd: 8296665: IGV: Show dialog with stack trace for exceptions
  • 277f0c2: 8296821: compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java fails after JDK-8262901
  • 34d10f1: 8296243: [IR Framework] Fix issues with IRNode.ALLOC* regexes
  • 8eb90e2: 8296797: java/nio/channels/vthread/BlockingChannelOps.testSocketChannelWriteAsyncClose failed with ClosedChannelException
  • a2cdcdd: 8296630: Fix SkipIfEqual on AArch64 and RISC-V
  • 657a0b2: 8295865: Several issues with os::realloc
  • ff2c987: 8294378: URLPermission constructor exception when using tr locale
  • 34a499d: 8294033: x86_64: libm stubs are missing
  • f0b648b: 8296758: [BACKOUT] Revert 8296115
  • 7f587e5: 8296872: gtest is built with the build-jdk
  • ... and 6 more: https://git.openjdk.org/jdk/compare/fdabd3796098c0ef0f528847da2cd98256443877...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 14, 2022
@AlanBateman
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 17, 2022

Going to push as commit 636040f.
Since your change was applied there have been 94 commits pushed to the master branch:

  • 2f728d0: 8295698: AArch64: test/jdk/sun/security/ec/ed/EdDSATest.java failed with -XX:+UseSHA3Intrinsics
  • b9db16a: 8288717: Add a means to close idle connections in HTTP/2 connection pool
  • 9f8b6d2: 8296437: NMT incurs costs if disabled
  • e81359f: 8296170: Refactor stack-locking path in C2_MacroAssembler::fast_unlock()
  • 502fa3e: 8296912: C2: CreateExNode::Identity fails with assert(i < _max) failed: oob: i=1, _max=1
  • 5795c76: 8296222: SwingEventMonitor - installListeners(Component , int ) - CELLEDITOR - bug
  • b9d6e83: 8296906: VMError::controlled_crash crashes with wrong code and address
  • cd9c688: 8276064: CheckCastPP with raw oop input floats below a safepoint
  • d61720a: 8218885: Restore pop_frame and force_early_return functionality for Graal
  • dd9aa72: 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM
  • ... and 84 more: https://git.openjdk.org/jdk/compare/fdabd3796098c0ef0f528847da2cd98256443877...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 17, 2022
@openjdk openjdk bot closed this Nov 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 17, 2022
@openjdk
Copy link

openjdk bot commented Nov 17, 2022

@AlanBateman Pushed as commit 636040f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants