8163229: several regression tests have a main method that is never executed

[archiecobbs]

This PR deals with some housekeeping relating to compiler unit tests.

JDK-8163229 points out that there are several tests that have a public static void main(String[]) method, but because the test expects to fail during compilation, the test is never actually run, and so these main methods are just clutter that can be removed.

However, there are also some tests where the test is never run, but the main() method generates one or more of the expected compilation errors. Obviously we need to keep those, but they don't need to be declared as public static void main(String[]) which is misleading. So instead we rename these methods to meth(), and also we remove the String[] parameter when it's not needed by the test.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8163229: several regression tests have a main method that is never executed

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10992/head:pull/10992
$ git checkout pull/10992

Update a local copy of the PR:
$ git checkout pull/10992
$ git pull https://git.openjdk.org/jdk pull/10992/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10992

View PR using the GUI difftool:
$ git pr show -t 10992

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10992.diff

[bridgekeeper]

👋 Welcome back archiecobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@archiecobbs The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (501289c4)
• 02: Full (6987fbda)
• 01: Full - Incremental (ee28175a)
• 00: Full (0dd3380c)

[openjdk]

@archiecobbs this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8163229
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[vicente-romero-oracle]

just minor suggestions, for your consideration which can be addressed as part of a follow-up bug, lgtm

[vicente-romero-oracle]

I have updated the bug title to a more general one, now the PR title need to be synced with it.

[vicente-romero-oracle]

looks good thanks

[openjdk]

@archiecobbs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8163229: several regression tests have a main method that is never executed

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 149 new commits pushed to the master branch:

• 1e99729: 8299274: Add elements to resolved_references consistently
• 8cc1669: 8299721: [Vector API] assert in switch-default of LibraryCallKit::arch_supports_vector_rotate is too weak to catch bugs
• 5598acc: 8294403: [REDO] make test should report only on executed tests
• 88f0ea7: 8299726: [cleanup] Some code cleanup in opto/compile.hpp
• 0234f81: 8298447: Unnecessary Vector usage in DocPrintJob implementations
• cc4936a: 8298720: Insufficient error handling when CodeBuffer is exhausted
• b5b7948: 8298240: Replace the usage of ImageLayoutException by the CMMException
• 99be740: 8299306: Test "javax/swing/JFileChooser/FileSystemView/CustomFSVLinkTest.java" fails on Windows 10 x64 because there are some buttons did not display button name
• 775da84: 8299412: JNI call of getAccessibleActionCount on a wrong thread
• 7845b0d: 8296934: Write a test to verify whether Undecorated Frame can be iconified or not
• ... and 139 more: https://git.openjdk.org/jdk/compare/da38d43fcc640ea9852db6c7c23817dcef7080d5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vicente-romero-oracle) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[archiecobbs]

/integrate

[openjdk]

@archiecobbs
Your change (at version 501289c) is now ready to be sponsored by a Committer.

[TheShermanTanker]

Verified that the test failures are unrelated, will help you sponsor

[TheShermanTanker]

/sponsor

[openjdk]

Going to push as commit 382fe51.
Since your change was applied there have been 291 commits pushed to the master branch:

• 06f9374: 8298867: Basics.java fails with SSL handshake exception
• 859ccd1: 8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes
• 240830d: 8297092: [macos_aarch64] Add support for SHA feature detection
• f52f6e6: 8299972: Remove metaprogramming/removeReference.hpp
• 4c1e66e: 8299971: Remove metaprogramming/conditional.hpp
• 4073b68: 8298047: Remove all non-significant trailing whitespace from properties files
• 506c818: 8296401: ConcurrentHashTable::bulk_delete might miss to delete some objects
• 319de6a: 8300124: Remove unnecessary assert in GenCollectedHeap::initialize
• 289aed4: 8298128: runtime/ErrorHandling/TestSigInfoInHsErrFile.java fails to find pattern with slowdebug
• a2f6766: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines
• ... and 281 more: https://git.openjdk.org/jdk/compare/da38d43fcc640ea9852db6c7c23817dcef7080d5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheShermanTanker @archiecobbs Pushed as commit 382fe51.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.