Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296239: ISO 4217 Amendment 174 Update #10994

Closed

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Nov 4, 2022

Incorporated ISO 174 Amendment update: Update Croatia's currency from Kuna to Euro (to take place on 1/1/2023).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10994/head:pull/10994
$ git checkout pull/10994

Update a local copy of the PR:
$ git checkout pull/10994
$ git pull https://git.openjdk.org/jdk pull/10994/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10994

View PR using the GUI difftool:
$ git pr show -t 10994

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10994.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 4, 2022

👋 Welcome back justin-curtis-lu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@justin-curtis-lu The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Nov 4, 2022
@@ -189,7 +189,7 @@ CR=CRC
# COTE D'IVOIRE
CI=XOF
# CROATIA
HR=HRK
HR=HRK;2022-12-31-21-00-00;EUR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Croatian time is GMT+1, the cutover time should be 2022-12-31-23-00-00 in GMT

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the change thank you

@@ -67,7 +67,7 @@ CD CDF 976 2
CK NZD 554 2
CR CRC 188 2
CI XOF 952 0
HR HRK 191 2
HR HRK 191 2 2022-12-31-21-00-00 EUR 978 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@justin-curtis-lu justin-curtis-lu marked this pull request as ready for review November 7, 2022 22:31
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 7, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 7, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296239: ISO 4217 Amendment 174 Update

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 71 new commits pushed to the master branch:

  • d9b25e8: 8296426: x86: Narrow UseAVX and UseSSE flags
  • 8146e1a: 8296347: Memory leak from ClassPathDirEntry::_dir
  • 671f84b: 8296143: CertAttrSet's set/get mechanism is not type-safe
  • d04d656: 8296433: Encountered null CLD while loading shared lambda proxy class
  • 74f2b16: 8295303: cleanup debug agent's confusing use of EI_GC_FINISH
  • 0ee25de: 8296504: Memory leak in G1PLABAllocator::PLABData
  • dd5d4df: 8295658: G1: Refactor G1SegmentedArray to indicate that it is an allocator
  • cf65605: 8296445: C++ syntax error in jdwpTransport.h
  • 1169dc0: 8296447: RISC-V: Make the operands order of vrsub_vx/vrsub_vi consistent with RVV 1.0 spec
  • 4c80dff: 8296435: RISC-V: Small refactoring for increment/decrement
  • ... and 61 more: https://git.openjdk.org/jdk/compare/f84b0ad07c73c305d21c71ec6b8195dc1ee31a3e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 8, 2022
@justin-curtis-lu
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 9, 2022
@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@justin-curtis-lu
Your change (at version a8a4714) is now ready to be sponsored by a Committer.

@naotoj
Copy link
Member

naotoj commented Nov 9, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 9, 2022

Going to push as commit fd83764.
Since your change was applied there have been 71 commits pushed to the master branch:

  • d9b25e8: 8296426: x86: Narrow UseAVX and UseSSE flags
  • 8146e1a: 8296347: Memory leak from ClassPathDirEntry::_dir
  • 671f84b: 8296143: CertAttrSet's set/get mechanism is not type-safe
  • d04d656: 8296433: Encountered null CLD while loading shared lambda proxy class
  • 74f2b16: 8295303: cleanup debug agent's confusing use of EI_GC_FINISH
  • 0ee25de: 8296504: Memory leak in G1PLABAllocator::PLABData
  • dd5d4df: 8295658: G1: Refactor G1SegmentedArray to indicate that it is an allocator
  • cf65605: 8296445: C++ syntax error in jdwpTransport.h
  • 1169dc0: 8296447: RISC-V: Make the operands order of vrsub_vx/vrsub_vi consistent with RVV 1.0 spec
  • 4c80dff: 8296435: RISC-V: Small refactoring for increment/decrement
  • ... and 61 more: https://git.openjdk.org/jdk/compare/f84b0ad07c73c305d21c71ec6b8195dc1ee31a3e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 9, 2022
@openjdk openjdk bot closed this Nov 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 9, 2022
@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@naotoj @justin-curtis-lu Pushed as commit fd83764.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
2 participants