New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8296239: ISO 4217 Amendment 174 Update #10994
8296239: ISO 4217 Amendment 174 Update #10994
Conversation
👋 Welcome back justin-curtis-lu! A progress list of the required criteria for merging this PR into |
@justin-curtis-lu The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
@@ -189,7 +189,7 @@ CR=CRC | |||
# COTE D'IVOIRE | |||
CI=XOF | |||
# CROATIA | |||
HR=HRK | |||
HR=HRK;2022-12-31-21-00-00;EUR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Croatian time is GMT+1
, the cutover time should be 2022-12-31-23-00-00
in GMT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the change thank you
@@ -67,7 +67,7 @@ CD CDF 976 2 | |||
CK NZD 554 2 | |||
CR CRC 188 2 | |||
CI XOF 952 0 | |||
HR HRK 191 2 | |||
HR HRK 191 2 2022-12-31-21-00-00 EUR 978 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
@justin-curtis-lu This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 71 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@justin-curtis-lu |
/sponsor |
Going to push as commit fd83764.
Your commit was automatically rebased without conflicts. |
@naotoj @justin-curtis-lu Pushed as commit fd83764. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Incorporated ISO 174 Amendment update: Update Croatia's currency from Kuna to Euro (to take place on 1/1/2023).
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10994/head:pull/10994
$ git checkout pull/10994
Update a local copy of the PR:
$ git checkout pull/10994
$ git pull https://git.openjdk.org/jdk pull/10994/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10994
View PR using the GUI difftool:
$ git pr show -t 10994
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10994.diff