Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297749: Remove duplicate space in the ProtocolException message being thrown from HttpURLConnection #11002

Closed
wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Nov 5, 2022

This PR removes a duplicate space in ProtocolException message.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297749: Remove duplicate space in the ProtocolException message being thrown from HttpURLConnection

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11002/head:pull/11002
$ git checkout pull/11002

Update a local copy of the PR:
$ git checkout pull/11002
$ git pull https://git.openjdk.org/jdk pull/11002/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11002

View PR using the GUI difftool:
$ git pr show -t 11002

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11002.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 5, 2022

👋 Welcome back izeye! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 5, 2022

@izeye The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Nov 5, 2022
@jaikiran
Copy link
Member

Hello @izeye, for this pull request to be officially reviewed, the process requires a JBS issue to be filed and linked against this PR. I have created https://bugs.openjdk.org/browse/JDK-8297749 to track this change.

Please update the title of this PR to 8297749: Remove duplicate space in the ProtocolException message being thrown from HttpURLConnection so that the necessary review process gets initiated.

@izeye izeye changed the title Remove duplicate space in ProtocolException message 8297749: Remove duplicate space in the ProtocolException message being thrown from HttpURLConnection Nov 29, 2022
@izeye
Copy link
Contributor Author

izeye commented Nov 29, 2022

@jaikiran Thanks for the feedback! I updated the title as you suggested.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 29, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 29, 2022

Webrevs

@@ -1996,8 +1996,7 @@ private InputStream getInputStream0() throws IOException {
return inputStream;
} while (redirects < maxRedirects);

throw new ProtocolException("Server redirected too many " +
" times ("+ redirects + ")");
throw new ProtocolException("Server redirected too many times ("+ redirects + ")");
Copy link
Member

@dfuch dfuch Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a missing space between " and + ; In order to avoid long lines which are a pain to review in side diffs I would suggest to reformat and add a newline there, rather than a whitespace.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfuch Thanks for the feedback! I updated as you suggested.

@openjdk
Copy link

openjdk bot commented Nov 29, 2022

@izeye Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Nov 29, 2022

@izeye This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297749: Remove duplicate space in the ProtocolException message being thrown from HttpURLConnection

Reviewed-by: dfuchs, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 341 new commits pushed to the master branch:

  • e10778a: 8297695: Fix typos in test/langtools files
  • 0ce1827: 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
  • e2d71c0: 8297481: Create a regression test for JDK-4424517
  • f4063a3: 8297210: Add a @sealedGraph tag to selected java.desktop classes
  • 2084451: 8078471: Backspace does not work in JFileChooser with GTK L&F
  • 7af6b4b: 8296012: jshell crashes on mismatched record pattern
  • ae5b1f7: 8297685: Typo in NullPointerException description specified by Locale.lookup
  • 3ce0042: 8297780: Problem list java/awt/Frame/RestoreToOppositeScreen/RestoreToOppositeScreen.java
  • b778cd5: 8295010: Reduce if required in EC limbs operations
  • 54e6d6a: 8293488: Add EOR3 backend rule for aarch64 SHA3 extension
  • ... and 331 more: https://git.openjdk.org/jdk/compare/581133a0c8c7d7e98614937c54db3723cd248f07...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch, @jaikiran) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 29, 2022
@izeye
Copy link
Contributor Author

izeye commented Nov 29, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 29, 2022
@openjdk
Copy link

openjdk bot commented Nov 29, 2022

@izeye
Your change (at version 6fcca31) is now ready to be sponsored by a Committer.

@jaikiran
Copy link
Member

Thank you @izeye for these changes. I'll run some tests with this change, just to be sure that this doesn't break anything unexpectedly (like any tests that might be relying on this error message). I'll sponsor this once the tests complete.

@jaikiran
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 30, 2022

Going to push as commit 5dcaf6c.
Since your change was applied there have been 346 commits pushed to the master branch:

  • c7a679f: 8297290: Use int indices to reference CDS archived primitive mirrors
  • 37f613b: 8297676: DataBuffer.TYPE_SHORT/TYPE_FLOAT/TYPE_DOUBLE are not placeholders
  • 87f00f4: 8296878: Document Filter attached to JPasswordField and setText("") is not cleared instead inserted characters replaced with unicode null characters
  • 9ced2ea: 8297311: Improve exception message thrown by java.net.HostPortrange::toLowerCase(String s)
  • defe060: 8296905: Replace the native LCMS#getProfileID() method with the accessor
  • e10778a: 8297695: Fix typos in test/langtools files
  • 0ce1827: 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
  • e2d71c0: 8297481: Create a regression test for JDK-4424517
  • f4063a3: 8297210: Add a @sealedGraph tag to selected java.desktop classes
  • 2084451: 8078471: Backspace does not work in JFileChooser with GTK L&F
  • ... and 336 more: https://git.openjdk.org/jdk/compare/581133a0c8c7d7e98614937c54db3723cd248f07...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 30, 2022
@openjdk openjdk bot closed this Nov 30, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 30, 2022
@openjdk
Copy link

openjdk bot commented Nov 30, 2022

@jaikiran @izeye Pushed as commit 5dcaf6c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
3 participants