Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255999: Shenandoah: Invoke native-LRB only on non-strong refs, again #1101

Closed
wants to merge 2 commits into from

Conversation

rkennke
Copy link
Contributor

@rkennke rkennke commented Nov 6, 2020

In JDK-8255691, I changed the condition for invoking native-LRB only on non-strong-refs. Somehow, when merging JDK-8254315, I got the condition wrong again.

Testing: hotspot_gc_shenandoah


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) (1/9 failed) ✔️ (9/9 passed) (1/9 failed) ✔️ (9/9 passed)

Failed test tasks

Issue

  • JDK-8255999: Shenandoah: Invoke native-LRB only on non-strong refs, again

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1101/head:pull/1101
$ git checkout pull/1101

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 6, 2020

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 6, 2020

@rkennke The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc shenandoah labels Nov 6, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 6, 2020

Webrevs

Copy link
Contributor

@zhengyu123 zhengyu123 left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 6, 2020

@rkennke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255999: Shenandoah: Invoke native-LRB only on non-strong refs, again

Reviewed-by: zgu, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 79b7909: 8255980: G1 Service thread register_task can be used after shutdown
  • dd8e4ff: 8255711: Fix and unify hotspot signal handlers

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 6, 2020
Copy link
Contributor

@shipilev shipilev left a comment

This makes sense. Looks good.

@rkennke
Copy link
Contributor Author

@rkennke rkennke commented Nov 10, 2020

I'm closing this PR. It will be subsumed by #1109.

@rkennke rkennke closed this Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc ready rfr shenandoah
3 participants