Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296504: Memory leak in G1PLABAllocator::PLABData #11032

Closed
wants to merge 1 commit into from

Conversation

caoman
Copy link
Contributor

@caoman caoman commented Nov 8, 2022

Hi all,

Could anyone review this fix for a memory leak identified by colleague Justin King (jcking@google.com) using LeakSanitizer?
I'm sponsoring Justin for this change.

-Man


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296504: Memory leak in G1PLABAllocator::PLABData

Reviewers

Contributors

  • Justin King <jcking@google.com>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11032/head:pull/11032
$ git checkout pull/11032

Update a local copy of the PR:
$ git checkout pull/11032
$ git pull https://git.openjdk.org/jdk pull/11032/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11032

View PR using the GUI difftool:
$ git pr show -t 11032

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11032.diff

Signed-off-by: Justin King <jcking@google.com>
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2022

👋 Welcome back manc! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 8, 2022
@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@caoman The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Nov 8, 2022
@caoman
Copy link
Contributor Author

caoman commented Nov 8, 2022

/contributor add Justin King jcking@google.com

@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@caoman
Contributor Justin King <jcking@google.com> successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 8, 2022

Webrevs

Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@caoman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296504: Memory leak in G1PLABAllocator::PLABData

Co-authored-by: Justin King <jcking@google.com>
Reviewed-by: kbarrett, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • dd5d4df: 8295658: G1: Refactor G1SegmentedArray to indicate that it is an allocator
  • cf65605: 8296445: C++ syntax error in jdwpTransport.h
  • 1169dc0: 8296447: RISC-V: Make the operands order of vrsub_vx/vrsub_vi consistent with RVV 1.0 spec
  • 4c80dff: 8296435: RISC-V: Small refactoring for increment/decrement
  • 47d2c7b: 8295376: Improve debug agent virtual thread performance when no debugger is attached

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 8, 2022
Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Lgtm.

@caoman
Copy link
Contributor Author

caoman commented Nov 8, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 8, 2022

Going to push as commit 0ee25de.
Since your change was applied there have been 5 commits pushed to the master branch:

  • dd5d4df: 8295658: G1: Refactor G1SegmentedArray to indicate that it is an allocator
  • cf65605: 8296445: C++ syntax error in jdwpTransport.h
  • 1169dc0: 8296447: RISC-V: Make the operands order of vrsub_vx/vrsub_vi consistent with RVV 1.0 spec
  • 4c80dff: 8296435: RISC-V: Small refactoring for increment/decrement
  • 47d2c7b: 8295376: Improve debug agent virtual thread performance when no debugger is attached

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 8, 2022
@openjdk openjdk bot closed this Nov 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 8, 2022
@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@caoman Pushed as commit 0ee25de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@caoman caoman deleted the JDK8296504 branch November 15, 2022 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
4 participants