8296275: Write a test to verify setAccelerator method of JMenuItem

[Naveenam-Oracle]

This testcase will

1. Verify setAccelerator method of JMenuitem.
2. Check that the selection of a menu item in the menu bar will generate action by a key combination of META+M.

Testing:
Tested using Mach5(20 times per platform) in Mac OS, Linux and Windows and got all pass.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296275: Write a test to verify setAccelerator method of JMenuItem

Reviewers

• Manukumar V S (@manukumarvs - Author) ⚠️ Review applies to 77c86dc7
• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11035/head:pull/11035
$ git checkout pull/11035

Update a local copy of the PR:
$ git checkout pull/11035
$ git pull https://git.openjdk.org/jdk pull/11035/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11035

View PR using the GUI difftool:
$ git pr show -t 11035

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11035.diff

[bridgekeeper]

Hi @Naveenam-Oracle, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user Naveenam-Oracle" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@Naveenam-Oracle The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 09: Full - Incremental (0fc8e25e)
• 08: Full - Incremental (fe62a7e3)
• 07: Full - Incremental (12cc8e4e)
• 06: Full - Incremental (2661e04e)
• 05: Full - Incremental (a8e13a4c)
• 04: Full - Incremental (a7c30098)
• 03: Full - Incremental (77c86dc7)
• 02: Full - Incremental (3dc79dd4)
• 01: Full - Incremental (19a0ba96)
• 00: Full (22dc9ee9)

[manukumarvs]

The JDK bug associated with an openjdk PR should not be a confidential one(I have changed it now).

[Naveenam-Oracle]

Any volunteers for a review?

[openjdk]

@Naveenam-Oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296275: Write a test to verify setAccelerator method of JMenuItem

Reviewed-by: mvs, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 745 new commits pushed to the master branch:

• 40cb431: 8298943: Missing escapes for single quote marks in compiler.properties
• 9194e91: 8298701: Cleanup SA entries in ProblemList-zgc.txt.
• 4c927df: 8298470: Short cut java.lang.Object super class loading
• 756a06d: 8299022: Linux ppc64le and s390x build issues after JDK-8160404
• de0ce79: 8297801: printnm crashes with invalid address due to null pointer dereference
• da38d43: 8296412: Special case infinite loops with unmerged backedges in IdealLoopTree::check_safepts
• 8e49fcd: 8295661: CompileTask::compile_id() should be passed as int
• 86d588b: 8283740: C1: Convert flag TwoOperandLIRForm to a constant on all platforms
• ec95991: 8298736: Revisit usages of log10 in compiler code
• 1622563: 8265688: Unused ciMethodType::ptype_at should be removed
• ... and 735 more: https://git.openjdk.org/jdk/compare/274ea1db5b248968c1ff1c5c24d75f07fb8a0600...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[Naveenam-Oracle]

/integrate auto

[openjdk]

@Naveenam-Oracle This pull request will be automatically integrated when it is ready

[Naveenam-Oracle]

@aivanov-jdk could you please sponsor.

[aivanov-jdk]

Since the test has nothing to do with Desktop class it should be moved to JMenuItem folder because it tests functionality of JMenuItem.

[Naveenam-Oracle]

@aivanov-jdk all review comments addressed. Can you please have a look.

[aivanov-jdk]

I have to repeat a more serious problem:

Since the test has nothing to do with Desktop class it should be moved to JMenuItem folder because it tests functionality of JMenuItem.

If it's supposed to test the Swing support for macOS global menu, then the test should do it.

Could you please clarify? If it's for regular JMenu and JMenuItem, move the test; if it's for the global menu, then modify the test accordingly.

[Naveenam-Oracle]

@aivanov-jdk, @mrserb all review comments addressed.

[openjdk]

/integrate

[openjdk]

@openjdk[bot]
Your change (at version 0fc8e25) is now ready to be sponsored by a Committer.

[Naveenam-Oracle]

/integrate

[openjdk]

@Naveenam-Oracle
Your change (at version 0fc8e25) is now ready to be sponsored by a Committer.

[aivanov-jdk]

/sponsor

[openjdk]

Going to push as commit b005013.
Since your change was applied there have been 780 commits pushed to the master branch:

• 85f9b37: 8297682: Use Collections.emptyIterator where applicable
• f36e144: 8299025: BMPImageReader.java readColorPalette could use staggeredReadByteStream
• f56285c: 8299146: No copyright statement on ArtifactResolverException.java
• 396a9bf: 8298913: Add override qualifiers to Relocation classes
• 386db07: Merge
• f4d7f43: 8299123: [BACKOUT] 4512626 Non-editable JTextArea provides no visual indication of keyboard focus
• 03afec1: 8298162: Test PrintClasses hits assert when run with code that retransform classes
• 03d9927: 8298061: vmTestbase/nsk/sysdict/vm/stress/btree/btree012/btree012.java failed with "fatal error: refcount has gone to zero"
• 65fc058: 8298968: G1: Incorrect merged remset stats
• 8dfb6d7: 8298651: Serial: Remove MarkSweep::follow_klass
• ... and 770 more: https://git.openjdk.org/jdk/compare/274ea1db5b248968c1ff1c5c24d75f07fb8a0600...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk @Naveenam-Oracle Pushed as commit b005013.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.