-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8296229: JFR: jfr tool should print unsigned values correctly #11039
Conversation
👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into |
@egahlin The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Co-authored-by: Justin King <jcking@google.com> Reviewed-by: kbarrett, tschatzl
Reviewed-by: amenkov, sspitsyn
Reviewed-by: iklam, dholmes
Reviewed-by: mullan
Co-authored-by: Justin King <jcking@google.com> Reviewed-by: dholmes, ccheung
Reviewed-by: vlivanov, kvn
Reviewed-by: naoto
Reviewed-by: naoto
…dReductionV node implementation Reviewed-by: luhenry, dzhang, yzhu, fyang
…Stream in LogSelection Reviewed-by: dholmes, rehn
LGTM |
@egahlin This change is no longer ready for integration - check the PR body for details. |
Reviewed-by: mullan
Reviewed-by: dcubed, mullan
Reviewed-by: weijun
Reviewed-by: michaelm
…tils Reviewed-by: sspitsyn, kevinw
Reviewed-by: aboldtch, stefank, simonis
Reviewed-by: mullan
…resolved Reviewed-by: rhalade
…Assembler::en/decode_klass_not_null Reviewed-by: fyang, yadongwang
…DMG contents Reviewed-by: asemenyuk
…ault Button not pressed for L&F: com.sun.java.swing.plaf.motif.MotifLookAndFeel Reviewed-by: tr, jdv
Reviewed-by: erikj, prr, ihse
…e loop Reviewed-by: prr
…ion and NullPointerException Reviewed-by: darcy
Reviewed-by: coleenp, stuefe, rehn, dholmes
…c type is T_BYTE/T_SHORT Reviewed-by: gcao, fyang, shade
@egahlin this pull request can not be integrated into git checkout printunsigned
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
Could I have a review of PR that fixes so unsigned numbers are printed correctly in the jfr tool.
Testing:
test/jdk/jdk/jfr
test/jdk/jdk/security/logging/
Thanks
Erik
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11039/head:pull/11039
$ git checkout pull/11039
Update a local copy of the PR:
$ git checkout pull/11039
$ git pull https://git.openjdk.org/jdk pull/11039/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11039
View PR using the GUI difftool:
$ git pr show -t 11039
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11039.diff