Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296229: JFR: jfr tool should print unsigned values correctly #11039

Closed
wants to merge 28 commits into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Nov 8, 2022

Could I have a review of PR that fixes so unsigned numbers are printed correctly in the jfr tool.

Testing:
test/jdk/jdk/jfr
test/jdk/jdk/security/logging/

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296229: JFR: jfr tool should print unsigned values correctly

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11039/head:pull/11039
$ git checkout pull/11039

Update a local copy of the PR:
$ git checkout pull/11039
$ git pull https://git.openjdk.org/jdk pull/11039/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11039

View PR using the GUI difftool:
$ git pr show -t 11039

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11039.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2022

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@egahlin The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-jfr
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org core-libs core-libs-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org labels Nov 8, 2022
Man Cao and others added 6 commits November 8, 2022 19:37
Co-authored-by: Justin King <jcking@google.com>
Reviewed-by: kbarrett, tschatzl
Co-authored-by: Justin King <jcking@google.com>
Reviewed-by: dholmes, ccheung
@egahlin egahlin marked this pull request as ready for review November 9, 2022 01:10
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 9, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 9, 2022

Webrevs

justin-curtis-lu and others added 4 commits November 9, 2022 01:18
…dReductionV node implementation

Reviewed-by: luhenry, dzhang, yzhu, fyang
…Stream in LogSelection

Reviewed-by: dholmes, rehn
@coffeys
Copy link
Contributor

coffeys commented Nov 9, 2022

LGTM

@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@egahlin This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 9, 2022
coffeys and others added 10 commits November 9, 2022 21:46
…Assembler::en/decode_klass_not_null

Reviewed-by: fyang, yadongwang
…ault Button not pressed for L&F: com.sun.java.swing.plaf.motif.MotifLookAndFeel

Reviewed-by: tr, jdv
…ion and NullPointerException

Reviewed-by: darcy
…c type is T_BYTE/T_SHORT

Reviewed-by: gcao, fyang, shade
@egahlin egahlin marked this pull request as draft November 10, 2022 13:51
@openjdk
Copy link

openjdk bot commented Nov 10, 2022

@egahlin this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout printunsigned
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added merge-conflict Pull request has merge conflict with target branch and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 10, 2022
@openjdk
Copy link

openjdk bot commented Nov 11, 2022

⚠️ @egahlin This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Nov 11, 2022
@egahlin egahlin closed this Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.