Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296611: Problemlist several sun/security tests until JDK-8295343 is resolved #11045

Closed

Conversation

mseledts
Copy link
Member

@mseledts mseledts commented Nov 8, 2022

Trivial change, updated jdk problem list.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296611: Problemlist several sun/security tests until JDK-8295343 is resolved

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11045/head:pull/11045
$ git checkout pull/11045

Update a local copy of the PR:
$ git checkout pull/11045
$ git pull https://git.openjdk.org/jdk pull/11045/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11045

View PR using the GUI difftool:
$ git pr show -t 11045

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11045.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2022

👋 Welcome back mseledtsov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 8, 2022
@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@mseledts To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@mseledts
Copy link
Member Author

mseledts commented Nov 9, 2022

@dcubed-ojdk Dan, could you please review this problem listing change ?

@mseledts
Copy link
Member Author

mseledts commented Nov 9, 2022

/label security

@openjdk openjdk bot added the security security-dev@openjdk.org label Nov 9, 2022
@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@mseledts
The security label was successfully added.

@mseledts
Copy link
Member Author

mseledts commented Nov 9, 2022

/label add security

@mseledts
Copy link
Member Author

mseledts commented Nov 9, 2022

/label add core-libs

@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@mseledts The security label was already applied.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 9, 2022
@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@mseledts
The core-libs label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 9, 2022

Webrevs

@seanjmullan
Copy link
Member

The java/security/cert/pkix/policyChanges/TestPolicy.java and java/security/cert/CertPathBuilder/targetConstraints/BuildEEBasicConstraints.java test failures are already fixed. There is no need to ProblemList them.

@mseledts
Copy link
Member Author

mseledts commented Nov 9, 2022

Thanks Sean. I will remove the fixed tests from the list.

@mseledts
Copy link
Member Author

mseledts commented Nov 9, 2022

I have updated the problem list to exclude fixed tests. Please review when you have a chance.

@rhalade
Copy link
Member

rhalade commented Nov 9, 2022

Please update the PR commit message in summary. I updated JBS bug summary to indicate only sun/security tests failed.

@mseledts mseledts changed the title 8296611: Problemlist several sun/security and java/security tests until JDK-8295343 is resolved 8296611: Problemlist several sun/security tests until JDK-8295343 is resolved Nov 10, 2022
@openjdk
Copy link

openjdk bot commented Nov 10, 2022

@mseledts This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296611: Problemlist several sun/security tests until JDK-8295343 is resolved

Reviewed-by: rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 102b2b3: 8292033: Move jdk.X509Certificate event logic to JCA layer
  • 1b94ae1: 8296139: Make GrowableBitMap the base class of all implementations
  • cc8bf95: 8296718: Refactor bootstrap Test Common Functionalities to test/lib/Utils
  • 17e3412: 8296615: use of undeclared identifier 'IPV6_DONTFRAG'
  • a5d838c: 8296591: Signature benchmark
  • fa8a866: 8296675: Exclude linux-aarch64 in NSS tests
  • d4376f8: 8296406: ChainingConstructors jtreg test reduce code duplication
  • 4a0093c: 8294362: UL: Replace the internal usage of manual buffers with stringStream in LogSelection
  • fef68bb: 8296515: RISC-V: Small refactoring for MaxReductionV/MinReductionV/AddReductionV node implementation
  • 82cbfb5: 8296140: Drop unused field java.util.Calendar.DATE_MASK
  • ... and 6 more: https://git.openjdk.org/jdk/compare/0ee25de704eb8f179888812bd9b1e7bebc384fd6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 10, 2022
@mseledts
Copy link
Member Author

Thank you Rajan.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 10, 2022

Going to push as commit d6e2d0d.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 102b2b3: 8292033: Move jdk.X509Certificate event logic to JCA layer
  • 1b94ae1: 8296139: Make GrowableBitMap the base class of all implementations
  • cc8bf95: 8296718: Refactor bootstrap Test Common Functionalities to test/lib/Utils
  • 17e3412: 8296615: use of undeclared identifier 'IPV6_DONTFRAG'
  • a5d838c: 8296591: Signature benchmark
  • fa8a866: 8296675: Exclude linux-aarch64 in NSS tests
  • d4376f8: 8296406: ChainingConstructors jtreg test reduce code duplication
  • 4a0093c: 8294362: UL: Replace the internal usage of manual buffers with stringStream in LogSelection
  • fef68bb: 8296515: RISC-V: Small refactoring for MaxReductionV/MinReductionV/AddReductionV node implementation
  • 82cbfb5: 8296140: Drop unused field java.util.Calendar.DATE_MASK
  • ... and 6 more: https://git.openjdk.org/jdk/compare/0ee25de704eb8f179888812bd9b1e7bebc384fd6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 10, 2022
@openjdk openjdk bot closed this Nov 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 10, 2022
@openjdk
Copy link

openjdk bot commented Nov 10, 2022

@mseledts Pushed as commit d6e2d0d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated security security-dev@openjdk.org
3 participants