-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8296611: Problemlist several sun/security tests until JDK-8295343 is resolved #11045
8296611: Problemlist several sun/security tests until JDK-8295343 is resolved #11045
Conversation
…il JDK-8295343 is resolved
👋 Welcome back mseledtsov! A progress list of the required criteria for merging this PR into |
@mseledts To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
@dcubed-ojdk Dan, could you please review this problem listing change ? |
/label security |
@mseledts |
/label add security |
/label add core-libs |
@mseledts The |
@mseledts |
Webrevs
|
The |
Thanks Sean. I will remove the fixed tests from the list. |
I have updated the problem list to exclude fixed tests. Please review when you have a chance. |
Please update the PR commit message in summary. I updated JBS bug summary to indicate only sun/security tests failed. |
@mseledts This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 16 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thank you Rajan. /integrate |
Going to push as commit d6e2d0d.
Your commit was automatically rebased without conflicts. |
Trivial change, updated jdk problem list.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11045/head:pull/11045
$ git checkout pull/11045
Update a local copy of the PR:
$ git checkout pull/11045
$ git pull https://git.openjdk.org/jdk pull/11045/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11045
View PR using the GUI difftool:
$ git pr show -t 11045
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11045.diff