Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8225116: Test OwnedWindowsLeak.java intermittently fails #1105

Closed
wants to merge 2 commits into from

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Nov 7, 2020

This test rarely fails in the past on some configurations but was never a problem listed, and according to the history of CI, it fails 2 times on its own this year.

There are two possible reasons for the failure:

  1. At that time we had a memory leak, which was fixed.
  2. The test works too fast and it was not enough time for GC to eliminate 1000 windows.

To make the future evaluation simpler I enhanced the test and make it stricter, see some comments inline.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8225116: Test OwnedWindowsLeak.java intermittently fails

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1105/head:pull/1105
$ git checkout pull/1105

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 7, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 7, 2020

@mrserb The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Nov 7, 2020
if (ref.get() != null)
{
throw new RuntimeException("Test FAILED: some of child windows are not GCed");
while (ref.get() != null) {
Copy link
Member Author

@mrserb mrserb Nov 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait till the end of the test and log what window is leaked. If it fails then it will be 100% product bug.

}
catch (NoSuchFieldException z)
{
System.out.println("Test PASSED: no 'ownedWindowList' field in Window class");
Copy link
Member Author

@mrserb mrserb Nov 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the field will be removed/renamed the test should be reworked.

{
throw new RuntimeException("Test FAILED: unexpected exception", z);
System.out.println("ownersChildren = " + ownersChildren);
Copy link
Member Author

@mrserb mrserb Nov 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This private list is cleared via the DIsposer mechanism, which may require additional time. If it fails then it will be 100% product bug.

@mrserb mrserb marked this pull request as ready for review Nov 7, 2020
@openjdk openjdk bot added the rfr label Nov 7, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 7, 2020

Webrevs

@mrserb
Copy link
Member Author

@mrserb mrserb commented Nov 30, 2020

Any volunteers for a review?

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 28, 2020

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member Author

@mrserb mrserb commented Dec 31, 2020

Any volunteers for a review?

@openjdk
Copy link

@openjdk openjdk bot commented Dec 31, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8225116: Test OwnedWindowsLeak.java intermittently fails

Reviewed-by: pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 756 new commits pushed to the master branch:

  • 8435f0d: 8258525: Some existing tests should use /nodynamiccopyright/ instead of the standard header
  • 07c93fa: Merge
  • 881bceb: 8258662: JDK 17ea: Crash compiling instanceof check involving sealed interface
  • fb607f1: 8245922: [macos] Taskbar.Feature.ICON_BADGE_NUMBER no longer supported on MacOS
  • 3f67afd: 8251377: [macos11] JTabbedPane selected tab text is barely legible
  • e2aa724: 8258941: Test specify the Classpath exception in the header
  • 779ee11: 8257147: [TESTBUG] Set a larger default loop count for the VectorAPI jtreg tests
  • 97c99b5: 8216400: improve handling of IOExceptions in JavaCompiler.close()
  • b575dd8: 8258914: javax/net/ssl/DTLS/RespondToRetransmit.java timed out
  • 57217b5: Merge
  • ... and 746 more: https://git.openjdk.java.net/jdk/compare/5dfb42fc68099278cbc98e25fb8a91fd957c12e2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 31, 2020
@mrserb
Copy link
Member Author

@mrserb mrserb commented Jan 3, 2021

/integrate

@openjdk openjdk bot closed this Jan 3, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 3, 2021

@mrserb Since your change was applied there have been 757 commits pushed to the master branch:

  • f5ee356: 8179503: Java should support GET OCSP calls
  • 8435f0d: 8258525: Some existing tests should use /nodynamiccopyright/ instead of the standard header
  • 07c93fa: Merge
  • 881bceb: 8258662: JDK 17ea: Crash compiling instanceof check involving sealed interface
  • fb607f1: 8245922: [macos] Taskbar.Feature.ICON_BADGE_NUMBER no longer supported on MacOS
  • 3f67afd: 8251377: [macos11] JTabbedPane selected tab text is barely legible
  • e2aa724: 8258941: Test specify the Classpath exception in the header
  • 779ee11: 8257147: [TESTBUG] Set a larger default loop count for the VectorAPI jtreg tests
  • 97c99b5: 8216400: improve handling of IOExceptions in JavaCompiler.close()
  • b575dd8: 8258914: javax/net/ssl/DTLS/RespondToRetransmit.java timed out
  • ... and 747 more: https://git.openjdk.java.net/jdk/compare/5dfb42fc68099278cbc98e25fb8a91fd957c12e2...master

Your commit was automatically rebased without conflicts.

Pushed as commit 497efef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8225116 branch Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants