Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296632: Write a test to verify the content change of TextArea sends TextEvent #11052

Closed
wants to merge 6 commits into from

Conversation

ravigupta30
Copy link
Contributor

@ravigupta30 ravigupta30 commented Nov 9, 2022

This testcase Verify the content changes of a TextArea for the following assertions.

a. TextListener get invoked when the content of a TextArea gets changed.
b. TextListener not get invoked during text selection or when Special keys such as Function Keys are pressed.

Testing:
Tested using Mach5(20 times per platform) in macos,linux and windows and got all pass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296632: Write a test to verify the content change of TextArea sends TextEvent

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11052/head:pull/11052
$ git checkout pull/11052

Update a local copy of the PR:
$ git checkout pull/11052
$ git pull https://git.openjdk.org/jdk pull/11052/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11052

View PR using the GUI difftool:
$ git pr show -t 11052

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11052.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 9, 2022

👋 Welcome back ravigupta30! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@ravigupta30 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 9, 2022
@ravigupta30 ravigupta30 changed the title Write a test to verify the content change of TextArea sends TextEvent. 8296632: Write a test to verify the content change of TextArea sends TextEvent. Nov 9, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 9, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 9, 2022

Webrevs

@manukumarvs
Copy link
Member

Please make sure the bug associated with a PR is a non-confidential one.

Copy link
Member

@manukumarvs manukumarvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use BUTTON1_DOWN_MASK everywhere

@lawrence-andrew
Copy link
Contributor

LGTM

@ravigupta30
Copy link
Contributor Author

Any volunteers for a review?

@openjdk
Copy link

openjdk bot commented Nov 16, 2022

⚠️ @ravigupta30 the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8296632
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Nov 16, 2022

@ravigupta30 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296632: Write a test to verify the content change of TextArea sends TextEvent

Reviewed-by: mvs, prr, honkar, aivanov, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 156 new commits pushed to the master branch:

  • 13158cb: 8293041: --disable-@files option doesn't work and cause an error
  • 761a4f4: 8295788: C2 compilation hits "assert((mode == ControlAroundStripMined && use == sfpt) || !use->is_reachable_from_root()) failed: missed a node"
  • 2f2d404: 8297129: Inflater documentation refers to 'deflate' methods
  • dd18d76: 8297173: usageTicks and totalTicks should be volatile to ensure that different threads get the latest ticks
  • 2b6dbc7: 8293856: AArch64: Remove clear_inst_mark from aarch64_enc_java_dynamic_call
  • 2f063b8: 8296846: Minor cleanup of some dead code in Flow.java
  • ab6b7ef: 8296901: Do not create unsigned certificate and CRL
  • 7b3984c: 8296463: Memory leak in JVM_StartThread with the integration of Virtual threads
  • 373e52c: 8296785: Use realloc for CHeap-allocated BitMaps
  • a53be20: 8282404: DrawStringWithInfiniteXform.java failed with "RuntimeException: drawString with InfiniteXform transform takes long time"
  • ... and 146 more: https://git.openjdk.org/jdk/compare/fd837649811c866c144c9133d211fb5ad8f994a7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @aivanov-jdk, @mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 16, 2022
@ravigupta30 ravigupta30 changed the title 8296632: Write a test to verify the content change of TextArea sends TextEvent. 8296632: Write a test to verify the content change of TextArea sends TextEvent Nov 17, 2022
@ravigupta30
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 18, 2022
@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@ravigupta30
Your change (at version 4a702aa) is now ready to be sponsored by a Committer.

@aivanov-jdk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 18, 2022

Going to push as commit 59a308b.
Since your change was applied there have been 162 commits pushed to the master branch:

  • 11fc65f: 8023562: [TEST_BUG] java/awt/Mouse/EnterExitEvents/DragWindowTest.java failed on ubuntu 13 and mac 10.11
  • 2c692aa: 8297088: Update LCMS to 2.14
  • 9b4e0e8: 8297080: Remove com/sun/jdi/NashornPopFrameTest.java from the problem list
  • 3272954: 8297083: Remove vmTestbase/nsk/jvmti/GetAllThreads/allthr001 from problem list
  • c4b6920: 8296910: Add EdDSA/XDH/RSASSA-PSS to KeyPairGeneratorBench.java
  • f34ca80: 8297245: JFR: TestRemoteDump should use RemoteRecordingStream
  • 13158cb: 8293041: --disable-@files option doesn't work and cause an error
  • 761a4f4: 8295788: C2 compilation hits "assert((mode == ControlAroundStripMined && use == sfpt) || !use->is_reachable_from_root()) failed: missed a node"
  • 2f2d404: 8297129: Inflater documentation refers to 'deflate' methods
  • dd18d76: 8297173: usageTicks and totalTicks should be volatile to ensure that different threads get the latest ticks
  • ... and 152 more: https://git.openjdk.org/jdk/compare/fd837649811c866c144c9133d211fb5ad8f994a7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 18, 2022
@openjdk openjdk bot closed this Nov 18, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 18, 2022
@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@aivanov-jdk @ravigupta30 Pushed as commit 59a308b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

8 participants