8296645: org.openjdk.bench.javax.tools.Javac leaves class files in current directory

[shipilev]

$ java -jar ../build/linux-x86_64-server-release/images/test/micro/benchmarks.jar org.openjdk.bench.javax.tools.Javac.testCompile -f 1 -r 1s -w 1s
...

$ ls
Apan.class

Additional testing:

• Eyeballing CWD and /tmp contents after the benchmark -- no leftovers

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296645: org.openjdk.bench.javax.tools.Javac leaves class files in current directory

Reviewers

• Claes Redestad (@cl4es - Reviewer)
• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11055/head:pull/11055
$ git checkout pull/11055

Update a local copy of the PR:
$ git checkout pull/11055
$ git pull https://git.openjdk.org/jdk pull/11055/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11055

View PR using the GUI difftool:
$ git pr show -t 11055

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11055.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[shipilev]

/label add compiler
/label add core-libs

[openjdk]

@shipilev
The compiler label was successfully added.

[openjdk]

@shipilev
The core-libs label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (f472ba6e)
• 00: Full (d272fc6b)

[shipilev]

Any takers? :)

[shipilev]

Anyone? :)

[cl4es]

LGTM

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296645: org.openjdk.bench.javax.tools.Javac leaves class files in current directory

Reviewed-by: redestad, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 213 new commits pushed to the master branch:

• 4e8e853: 6788481: CellEditorListener.editingCanceled is never called
• 692bedb: 8297106: Remove the -Xcheck:jni local reference capacity checking
• 05128c2: 8286185: The Java manpage can be more platform inclusive
• d450314: 8297276: Remove thread text from Subject.current
• cdf9ed0: 8297528: java/io/File/TempDirDoesNotExist.java test failing on windows-x64
• 105d9d7: 8295351: java/lang/Float/Binary16Conversion.java fails with "Unexpected result of converting"
• a80552e: 8236919: Refactor com.sun.tools.javac.main.CommandLine into a reusable module for other JDK tools
• a249a52: 8296754: AutoCreateSharedArchive in JDK 20 is not compatible with JDK 19
• 405b188: 8297570: jdk/jfr/threading/TestDeepVirtualStackTrace.java fails with -XX:-UseTLAB
• ba0a252: 8297717: Remove jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java from ProblemList
• ... and 203 more: https://git.openjdk.org/jdk/compare/c49e48417d8e58dc34455cb5b503a1ba83a710aa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jaikiran]

Looks fine to me. The copyright year will need an update.

[shipilev]

Thanks!

/integrate

[openjdk]

Going to push as commit bd51b7e.
Since your change was applied there have been 216 commits pushed to the master branch:

• b27a61e: 8297216: Search results omit some methods
• 33dfc7d: 8296954: G1: Enable parallel scanning for heap region remset
• 6f06f44: 8297242: Use-after-free during library unloading on Linux
• 4e8e853: 6788481: CellEditorListener.editingCanceled is never called
• 692bedb: 8297106: Remove the -Xcheck:jni local reference capacity checking
• 05128c2: 8286185: The Java manpage can be more platform inclusive
• d450314: 8297276: Remove thread text from Subject.current
• cdf9ed0: 8297528: java/io/File/TempDirDoesNotExist.java test failing on windows-x64
• 105d9d7: 8295351: java/lang/Float/Binary16Conversion.java fails with "Unexpected result of converting"
• a80552e: 8236919: Refactor com.sun.tools.javac.main.CommandLine into a reusable module for other JDK tools
• ... and 206 more: https://git.openjdk.org/jdk/compare/c49e48417d8e58dc34455cb5b503a1ba83a710aa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit bd51b7e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.