Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296675: Exclude linux-aarch64 in NSS tests #11063

Closed
wants to merge 2 commits into from

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented Nov 9, 2022

The NSS tests do not work fine on linux-aarch64 now. Disable them at the moment.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11063/head:pull/11063
$ git checkout pull/11063

Update a local copy of the PR:
$ git checkout pull/11063
$ git pull https://git.openjdk.org/jdk pull/11063/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11063

View PR using the GUI difftool:
$ git pr show -t 11063

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11063.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 9, 2022

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. This is a trivial fix.

Do we know if these tests will also fail on linux-x64 OL9?

@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296675: Exclude linux-aarch64 in NSS tests

Reviewed-by: dcubed, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • d4376f8: 8296406: ChainingConstructors jtreg test reduce code duplication
  • 4a0093c: 8294362: UL: Replace the internal usage of manual buffers with stringStream in LogSelection
  • fef68bb: 8296515: RISC-V: Small refactoring for MaxReductionV/MinReductionV/AddReductionV node implementation
  • 82cbfb5: 8296140: Drop unused field java.util.Calendar.DATE_MASK
  • fd83764: 8296239: ISO 4217 Amendment 174 Update
  • d9b25e8: 8296426: x86: Narrow UseAVX and UseSSE flags
  • 8146e1a: 8296347: Memory leak from ClassPathDirEntry::_dir

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 9, 2022
@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@wangweij The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Nov 9, 2022
@wangweij
Copy link
Contributor Author

wangweij commented Nov 9, 2022

Do we know if these tests will also fail on linux-x64 OL9?

For linux-x64, we use libraries from the artifact server and they succeed on OL9.

@seanjmullan
Copy link
Member

I guess it's not possible to ProblemList an OS/arch combo?

@mlbridge
Copy link

mlbridge bot commented Nov 9, 2022

Webrevs

"/usr/lib/aarch64-linux-gnu/",
"/usr/lib/aarch64-linux-gnu/nss/",
"/usr/lib64/" });
// osMap.put("Linux-aarch64-64", new String[] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add a comment above this noting why these are being excluded. Could include the bugid for now until it is fixed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@wangweij
Copy link
Contributor Author

wangweij commented Nov 9, 2022

I guess it's not possible to ProblemList an OS/arch combo?

Yes, we can, but there are quite a lot of tests failing here.

@seanjmullan
Copy link
Member

I guess it's not possible to ProblemList an OS/arch combo?

Yes, we can, but there are quite a lot of tests failing here.

Seems fine then.

Copy link
Member

@seanjmullan seanjmullan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug needs noreg-self label. Otherwise, looks good.

@wangweij
Copy link
Contributor Author

wangweij commented Nov 9, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 9, 2022

Going to push as commit fa8a866.
Since your change was applied there have been 7 commits pushed to the master branch:

  • d4376f8: 8296406: ChainingConstructors jtreg test reduce code duplication
  • 4a0093c: 8294362: UL: Replace the internal usage of manual buffers with stringStream in LogSelection
  • fef68bb: 8296515: RISC-V: Small refactoring for MaxReductionV/MinReductionV/AddReductionV node implementation
  • 82cbfb5: 8296140: Drop unused field java.util.Calendar.DATE_MASK
  • fd83764: 8296239: ISO 4217 Amendment 174 Update
  • d9b25e8: 8296426: x86: Narrow UseAVX and UseSSE flags
  • 8146e1a: 8296347: Memory leak from ClassPathDirEntry::_dir

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 9, 2022
@openjdk openjdk bot closed this Nov 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 9, 2022
@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@wangweij Pushed as commit fa8a866.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wangweij wangweij deleted the 8296675 branch November 9, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
3 participants