Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296156: [macos] Resize DMG windows and background to fit additional DMG contents #11068

Closed
wants to merge 1 commit into from

Conversation

sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Nov 9, 2022

Additional DMG content will be arranged in raws with 3 items per raw. DMG windows will be resized to show one or two raws without any scrolling required. To see any additional content after two raws (7 or more items) user will need to use vertical scroll bar. See JBS for screen shots.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296156: [macos] Resize DMG windows and background to fit additional DMG contents

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11068/head:pull/11068
$ git checkout pull/11068

Update a local copy of the PR:
$ git checkout pull/11068
$ git pull https://git.openjdk.org/jdk pull/11068/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11068

View PR using the GUI difftool:
$ git pr show -t 11068

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11068.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 9, 2022

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 9, 2022
@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@sashamatveev The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 9, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 9, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 10, 2022

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296156: [macos] Resize DMG windows and background to fit additional DMG contents

Reviewed-by: asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • d6e2d0d: 8296611: Problemlist several sun/security tests until JDK-8295343 is resolved
  • 102b2b3: 8292033: Move jdk.X509Certificate event logic to JCA layer
  • 1b94ae1: 8296139: Make GrowableBitMap the base class of all implementations
  • cc8bf95: 8296718: Refactor bootstrap Test Common Functionalities to test/lib/Utils
  • 17e3412: 8296615: use of undeclared identifier 'IPV6_DONTFRAG'
  • a5d838c: 8296591: Signature benchmark
  • fa8a866: 8296675: Exclude linux-aarch64 in NSS tests
  • d4376f8: 8296406: ChainingConstructors jtreg test reduce code duplication
  • 4a0093c: 8294362: UL: Replace the internal usage of manual buffers with stringStream in LogSelection
  • fef68bb: 8296515: RISC-V: Small refactoring for MaxReductionV/MinReductionV/AddReductionV node implementation
  • ... and 15 more: https://git.openjdk.org/jdk/compare/7e85b41d37c5eec9693cfc07447f5deffd5d483b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 10, 2022
@sashamatveev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 10, 2022

Going to push as commit 0981bfb.
Since your change was applied there have been 26 commits pushed to the master branch:

  • 93fed9b: 8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null
  • d6e2d0d: 8296611: Problemlist several sun/security tests until JDK-8295343 is resolved
  • 102b2b3: 8292033: Move jdk.X509Certificate event logic to JCA layer
  • 1b94ae1: 8296139: Make GrowableBitMap the base class of all implementations
  • cc8bf95: 8296718: Refactor bootstrap Test Common Functionalities to test/lib/Utils
  • 17e3412: 8296615: use of undeclared identifier 'IPV6_DONTFRAG'
  • a5d838c: 8296591: Signature benchmark
  • fa8a866: 8296675: Exclude linux-aarch64 in NSS tests
  • d4376f8: 8296406: ChainingConstructors jtreg test reduce code duplication
  • 4a0093c: 8294362: UL: Replace the internal usage of manual buffers with stringStream in LogSelection
  • ... and 16 more: https://git.openjdk.org/jdk/compare/7e85b41d37c5eec9693cfc07447f5deffd5d483b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 10, 2022
@openjdk openjdk bot closed this Nov 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 10, 2022
@openjdk
Copy link

openjdk bot commented Nov 10, 2022

@sashamatveev Pushed as commit 0981bfb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants