Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296741: Illegal X400Address and EDIPartyName should not be created #11071

Closed
wants to merge 2 commits into from

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented Nov 9, 2022

EDIPartyName should not have a null partyName.

Inside X400Name it should be a DerValue instead of arbitrary byte array. Note: in GeneralSubtrees.java, an X400Name is created with a null content. This would lead to an NPE anyway. A future fix might be needed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296741: Illegal X400Address and EDIPartyName should not be created

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11071/head:pull/11071
$ git checkout pull/11071

Update a local copy of the PR:
$ git checkout pull/11071
$ git pull https://git.openjdk.org/jdk pull/11071/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11071

View PR using the GUI difftool:
$ git pr show -t 11071

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11071.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 9, 2022

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 9, 2022
@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@wangweij The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Nov 9, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 9, 2022

Webrevs

only in patch2:
unchanged:
Comment on lines 64 to +66
public EDIPartyName(String assignerName, String partyName) {
this.assigner = assignerName;
this.party = partyName;
this.party = Objects.requireNonNull(partyName);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this constructor is not used. Is if safe to remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not used inside JDK. But for completeness it sounds there should be a way to create one with an assigner.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused code means useless cost. For private package, it may be nice to keep compact and no unused code. As the class is public, I'm fine to leave as it is if you want to.

Comment on lines 64 to +66
public EDIPartyName(String assignerName, String partyName) {
this.assigner = assignerName;
this.party = partyName;
this.party = Objects.requireNonNull(partyName);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused code means useless cost. For private package, it may be nice to keep compact and no unused code. As the class is public, I'm fine to leave as it is if you want to.

@openjdk
Copy link

openjdk bot commented Nov 10, 2022

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296741: Illegal X400Address and EDIPartyName should not be created

Reviewed-by: xuelei, valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • 2f9a94f: 8296824: ProblemList compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java
  • 43ebd96: 8296822: ProblemList jdk/jfr/api/consumer/TestRecordingFileWrite.java
  • 84e1224: 8296496: Overzealous check in sizecalc.h prevents large memory allocation
  • 27527b4: 8296612: CertAttrSet is useless
  • 6b456f7: 8262901: [macos_aarch64] NativeCallTest expected:<-3.8194101E18> but was:<3.02668882E10>
  • e1badb7: 8295871: G1: Use different explicit claim marks for CLDs
  • 9ef7852: 8290714: Make com.sun.jndi.dns.DnsClient virtual threads friendly
  • d6468be: 8293886: The abstract keyword can be removed in AESCipher
  • 54c986e: 8296715: CLDR v42 update for tzdata 2022f
  • 4a68210: 6972078: Can not select single directory with GTKLookAndFeel
  • ... and 12 more: https://git.openjdk.org/jdk/compare/cc8bf95046d1fba0f88b0e17481f36b2be870659...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 10, 2022
@wangweij
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 14, 2022

Going to push as commit e1d298c.
Since your change was applied there have been 46 commits pushed to the master branch:

  • b0edfc1: 8164464: Consistent failure of java/awt/dnd/MissingEventsOnModalDialog/MissingEventsOnModalDialogTest.java
  • 9c39932: 8294899: Process.waitFor() throws IllegalThreadStateException when a process on Windows returns an exit code of 259
  • 3f401b3: 8296670: G1: Remove unused G1GCPhaseTimes::record_preserve_cm_referents_time_ms
  • 68301cd: 8296665: IGV: Show dialog with stack trace for exceptions
  • 277f0c2: 8296821: compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java fails after JDK-8262901
  • 34d10f1: 8296243: [IR Framework] Fix issues with IRNode.ALLOC* regexes
  • 8eb90e2: 8296797: java/nio/channels/vthread/BlockingChannelOps.testSocketChannelWriteAsyncClose failed with ClosedChannelException
  • a2cdcdd: 8296630: Fix SkipIfEqual on AArch64 and RISC-V
  • 657a0b2: 8295865: Several issues with os::realloc
  • ff2c987: 8294378: URLPermission constructor exception when using tr locale
  • ... and 36 more: https://git.openjdk.org/jdk/compare/cc8bf95046d1fba0f88b0e17481f36b2be870659...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 14, 2022
@openjdk openjdk bot closed this Nov 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 14, 2022
@openjdk
Copy link

openjdk bot commented Nov 14, 2022

@wangweij Pushed as commit e1d298c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wangweij wangweij deleted the 8296741 branch November 14, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
3 participants