8296638: RISC-V: NegVI node emits wrong code when vector element basic type is T_BYTE/T_SHORT

[DingliZhang]

Hi,

test/jdk/jdk/incubator/vector/Byte256VectorTests.java fails on riscv with the following error:

test Byte256VectorTests.negByte256VectorTests (byte [i * 5]): failure
java.lang.AssertionError: at index #2, input = 10 expected [-10] but found [-11]

Currently, NegVI can only handle the vector element basic type T_INT withvsetvli(t0, x0, Assembler::e32) but T_SHORT/T_BYTE can also be matched with NegVI, so these two types of tests are currently failing:

test/jdk/jdk/incubator/vector/Byte*VectorTests.java
test/jdk/jdk/incubator/vector/Short*VectorTests.java

Meanwhile, I removed some useless trailing whitespace.

Please take a look and have some reviews. Thanks a lot.

Testing:

• test/jdk/jdk/incubator/vector (fastdebug/release with UseRVV on QEMU)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296638: RISC-V: NegVI node emits wrong code when vector element basic type is T_BYTE/T_SHORT

Reviewers

• Gui Cao (@zifeihan - Author)
• Fei Yang (@RealFYang - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11074/head:pull/11074
$ git checkout pull/11074

Update a local copy of the PR:
$ git checkout pull/11074
$ git pull https://git.openjdk.org/jdk pull/11074/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11074

View PR using the GUI difftool:
$ git pr show -t 11074

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11074.diff

[bridgekeeper]

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DingliZhang The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (a5a04735)
• 00: Full (378fe8db)

[zifeihan]

LGTM, Thanks!

[RealFYang]

Looks reasonable.

[openjdk]

@DingliZhang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296638: RISC-V: NegVI node emits wrong code when vector element basic type is T_BYTE/T_SHORT

Reviewed-by: gcao, fyang, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• bfc5816: 8295475: Move non-resource allocation strategies out of ResourceObj
• e802b12: 8296196: Class.getEnumConstants() throws undocumented ClassCastException and NullPointerException
• 78a08a0: 8295430: Use cmsDoTransformLineStride instead of cmsDoTransform in the loop
• f0a6e71: 8295812: Skip the "half float" support in LittleCMS during the build
• 79c0092: 8285635: javax/swing/JRootPane/DefaultButtonTest.java failed with Default Button not pressed for L&F: com.sun.java.swing.plaf.motif.MotifLookAndFeel
• 0981bfb: 8296156: [macos] Resize DMG windows and background to fit additional DMG contents

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[DingliZhang]

@zifeihan @RealFYang Thanks for the review!
/integrate

[openjdk]

@DingliZhang
Your change (at version a5a0473) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit f2acdfd.
Since your change was applied there have been 6 commits pushed to the master branch:

• bfc5816: 8295475: Move non-resource allocation strategies out of ResourceObj
• e802b12: 8296196: Class.getEnumConstants() throws undocumented ClassCastException and NullPointerException
• 78a08a0: 8295430: Use cmsDoTransformLineStride instead of cmsDoTransform in the loop
• f0a6e71: 8295812: Skip the "half float" support in LittleCMS during the build
• 79c0092: 8285635: javax/swing/JRootPane/DefaultButtonTest.java failed with Default Button not pressed for L&F: com.sun.java.swing.plaf.motif.MotifLookAndFeel
• 0981bfb: 8296156: [macos] Resize DMG windows and background to fit additional DMG contents

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @DingliZhang Pushed as commit f2acdfd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.