8296733: JFR: File Read event for RandomAccessFile::write(byte[]) is incorrect

[egahlin]

The jdk.FileRead event emits an incorrect duration. This could lead to flooded buffers when using the default configuration.

Testing: test/jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296733: JFR: File Read event for RandomAccessFile::write(byte[]) is incorrect

Reviewers

• Christoph Langer (@RealCLanger - Reviewer)
• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11075/head:pull/11075
$ git checkout pull/11075

Update a local copy of the PR:
$ git checkout pull/11075
$ git pull https://git.openjdk.org/jdk pull/11075/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11075

View PR using the GUI difftool:
$ git pr show -t 11075

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11075.diff

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3a46a018)

[RealCLanger]

Looks obvious. Thanks for fixing.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296733: JFR: File Read event for RandomAccessFile::write(byte[]) is incorrect

Reviewed-by: clanger, mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• f2acdfd: 8296638: RISC-V: NegVI node emits wrong code when vector element basic type is T_BYTE/T_SHORT
• bfc5816: 8295475: Move non-resource allocation strategies out of ResourceObj
• e802b12: 8296196: Class.getEnumConstants() throws undocumented ClassCastException and NullPointerException
• 78a08a0: 8295430: Use cmsDoTransformLineStride instead of cmsDoTransform in the loop
• f0a6e71: 8295812: Skip the "half float" support in LittleCMS during the build
• 79c0092: 8285635: javax/swing/JRootPane/DefaultButtonTest.java failed with Default Button not pressed for L&F: com.sun.java.swing.plaf.motif.MotifLookAndFeel
• 0981bfb: 8296156: [macos] Resize DMG windows and background to fit additional DMG contents
• 93fed9b: 8296448: RISC-V: Fix temp usages of heapbase register killed by MacroAssembler::en/decode_klass_not_null

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit ced88a2.
Since your change was applied there have been 28 commits pushed to the master branch:

• 87b809a: 8296229: JFR: jfr tool should print unsigned values correctly
• e7c2a8e: 8295214: Generational ZGC: Guard nmethods from cross modifying code
• d4d183e: 8296301: Interpreter(RISC-V): Implement -XX:+PrintBytecodeHistogram and -XX:+PrintBytecodePairHistogram options
• f754840: 8296773: G1: Factor out hash function for G1CardSet
• fdabd37: 8293696: java/nio/channels/DatagramChannel/SelectWhenRefused.java fails with "Unexpected wakeup"
• 4a30081: 8296747: com/sun/net/httpserver/simpleserver/StressDirListings.java timed out
• 12e76cb: 8296349: [aarch64] Avoid slicing Address::extend
• 7244eac: 8296771: RISC-V: C2: assert(false) failed: bad AD file
• 956d75b: 8295099: vmTestbase/nsk/stress/strace/strace013.java failed with "TestFailure: wrong lengths of stack traces: strace013Thread0: NNN strace013Thread83: MMM"
• 2f9a94f: 8296824: ProblemList compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java
• ... and 18 more: https://git.openjdk.org/jdk/compare/d6e2d0d03d2161f934474fa1d4299513d14cb9c5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit ced88a2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.