Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8066622 8066637: remove deprecated using java.io.File.toURL() in internal classes #1108

Closed
wants to merge 1 commit into from
Closed

8066622 8066637: remove deprecated using java.io.File.toURL() in internal classes #1108

wants to merge 1 commit into from

Conversation

bastie
Copy link

@bastie bastie commented Nov 7, 2020

In result of Javadoc to do not use java.io.File.toURL()
Change use java.io.File.toURL().toURI() instead.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8066622

Issue

  • JDK-8066622: Fix deprecation warnings in java.desktop module ⚠️ Title mismatch between PR and JBS.

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1108/head:pull/1108
$ git checkout pull/1108

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 7, 2020

👋 Welcome back bastie! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 7, 2020

@bastie The following labels will be automatically applied to this pull request:

  • awt
  • core-libs
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability core-libs awt labels Nov 7, 2020
@bastie bastie changed the title remove deprecated using java.io.File.toURL() in internal classes 8066622 8066637: remove deprecated using java.io.File.toURL() in internal classes Nov 7, 2020
@openjdk openjdk bot added the rfr label Nov 7, 2020
@bastie
Copy link
Author

@bastie bastie commented Nov 7, 2020

8066622 8066637: only for java.io.File.toURL

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 7, 2020

Webrevs

Copy link
Contributor

@prrace prrace left a comment

You reference a desktop bug that discusses many, many deprecations
and skara has identified https://bugs.openjdk.java.net/browse/JDK-8066622
as the issue being fixed.
Yet you propose to fix precisely one of these.
But when this is integrated that bug will be closed out as resolved.
I think you need a new bug about JUST the changes you are making.
So I don't think you should use that bug id any where in this PR.
And I'd like to hear whether you actually tested splashscreen with your change ? I see no sign that you did.

@prrace
Copy link
Contributor

@prrace prrace commented Nov 8, 2020

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Nov 8, 2020

@prrace
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@bastie
Copy link
Author

@bastie bastie commented Nov 10, 2020

You reference a desktop bug that discusses many, many deprecations ...
Yep. In my opinion this is a bot problem here and need other place to discuss.

Yet you propose to fix precisely one of these.
@prrace: Not really.
The way to work with problems differ. Both bugs - maybe these are more quality change requests than bugs - are bullet lists and are created on build process. The different is, I work on single quality tests and remove deprecated code from source base. So in my clean Java build the method java.io.File.toUrl() does not(!) exist.
Because java.io.File.toURL() doesn't exist, also two patches are needed for JDK build process (internal I use diff-patch).

And I'd like to hear whether you actually tested splashscreen with your change ? I see no sign that you did.
I'm not sure, what you want to listen. I work with a clean Java build with patch to remove java.io.File.toURL() and change the collateral damages.

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 8, 2020

@bastie This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 5, 2021

@bastie This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it!

@bridgekeeper bridgekeeper bot closed this Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awt core-libs rfr serviceability
2 participants