8296773: G1: Factor out hash function for G1CardSet

[tschatzl]

Hi all,

please review this refactoring that removes the inlining of the "hash" in G1CardSet to call a common function.
This makes experimenting with different hash functions much easier.

Testing: local compilation, gha

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296773: G1: Factor out hash function for G1CardSet

Reviewers

• Ivan Walulya (@walulyai - Reviewer)
• Kim Barrett (@kimbarrett - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11087/head:pull/11087
$ git checkout pull/11087

Update a local copy of the PR:
$ git checkout pull/11087
$ git pull https://git.openjdk.org/jdk pull/11087/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11087

View PR using the GUI difftool:
$ git pr show -t 11087

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11087.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (fed543c2)

[walulyai]

Lgtm!

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296773: G1: Factor out hash function for G1CardSet

Reviewed-by: iwalulya, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• 956d75b: 8295099: vmTestbase/nsk/stress/strace/strace013.java failed with "TestFailure: wrong lengths of stack traces: strace013Thread0: NNN strace013Thread83: MMM"
• 2f9a94f: 8296824: ProblemList compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java
• 43ebd96: 8296822: ProblemList jdk/jfr/api/consumer/TestRecordingFileWrite.java
• 84e1224: 8296496: Overzealous check in sizecalc.h prevents large memory allocation
• 27527b4: 8296612: CertAttrSet is useless
• 6b456f7: 8262901: [macos_aarch64] NativeCallTest expected:<-3.8194101E18> but was:<3.02668882E10>
• e1badb7: 8295871: G1: Use different explicit claim marks for CLDs
• 9ef7852: 8290714: Make com.sun.jndi.dns.DnsClient virtual threads friendly
• d6468be: 8293886: The abstract keyword can be removed in AESCipher
• 54c986e: 8296715: CLDR v42 update for tzdata 2022f
• ... and 2 more: https://git.openjdk.org/jdk/compare/f2acdfdcbd2a49c1167656e73b67b38b545f9472...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kimbarrett]

Looks good.

[tschatzl]

Thanks @kimbarrett @walulyai for your reviews
/integrate

[openjdk]

Going to push as commit f754840.
Since your change was applied there have been 16 commits pushed to the master branch:

• fdabd37: 8293696: java/nio/channels/DatagramChannel/SelectWhenRefused.java fails with "Unexpected wakeup"
• 4a30081: 8296747: com/sun/net/httpserver/simpleserver/StressDirListings.java timed out
• 12e76cb: 8296349: [aarch64] Avoid slicing Address::extend
• 7244eac: 8296771: RISC-V: C2: assert(false) failed: bad AD file
• 956d75b: 8295099: vmTestbase/nsk/stress/strace/strace013.java failed with "TestFailure: wrong lengths of stack traces: strace013Thread0: NNN strace013Thread83: MMM"
• 2f9a94f: 8296824: ProblemList compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java
• 43ebd96: 8296822: ProblemList jdk/jfr/api/consumer/TestRecordingFileWrite.java
• 84e1224: 8296496: Overzealous check in sizecalc.h prevents large memory allocation
• 27527b4: 8296612: CertAttrSet is useless
• 6b456f7: 8262901: [macos_aarch64] NativeCallTest expected:<-3.8194101E18> but was:<3.02668882E10>
• ... and 6 more: https://git.openjdk.org/jdk/compare/f2acdfdcbd2a49c1167656e73b67b38b545f9472...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit f754840.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.