Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8295813: misc client tests failing on Windows_11_Pro #11097

Closed
wants to merge 1 commit into from

Conversation

honkar-jdk
Copy link
Contributor

@honkar-jdk honkar-jdk commented Nov 10, 2022

ViewportOverlapping test was failing intermittently on Windows_11_Pro. The test has been updated to run at uiScale=1 to position the mouse clicks at correct locations and the deprecated InputEvent.BUTTON1_MASK is replaced with BUTTON1_DOWN_MASK.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295813: misc client tests failing on Windows_11_Pro

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11097/head:pull/11097
$ git checkout pull/11097

Update a local copy of the PR:
$ git checkout pull/11097
$ git pull https://git.openjdk.org/jdk pull/11097/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11097

View PR using the GUI difftool:
$ git pr show -t 11097

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11097.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 10, 2022

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 10, 2022
@openjdk
Copy link

openjdk bot commented Nov 10, 2022

@honkar-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 10, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 10, 2022

Webrevs

@honkar-jdk honkar-jdk changed the title JDK-8295813: AWT_Mixing/ViewportOverlapping.java failing on Windows_11_Pro JDK-8295813: misc client tests failing on Windows_11_Pro Nov 11, 2022
@mrserb
Copy link
Member

mrserb commented Nov 11, 2022

What is changed in Windows 11 that the test fails on the HiDPI monitor?

@honkar-jdk honkar-jdk marked this pull request as draft November 11, 2022 17:41
@openjdk openjdk bot removed the rfr Pull request is ready for review label Nov 11, 2022
@honkar-jdk
Copy link
Contributor Author

honkar-jdk commented Nov 17, 2022

What is changed in Windows 11 that the test fails on the HiDPI monitor?

@mrserb Earlier I thought the intermittent issue might be due to wrong color being picked up or incorrect click location by Robot at the edges of component (in HiDPI). But it seems to be happening only when a batch of AWT_Mixing tests are run on Win11. There are couple of more client tests being analyzed as part this bug currently, hence converting this PR into draft until further updates.

@honkar-jdk honkar-jdk closed this Dec 19, 2022
@honkar-jdk honkar-jdk deleted the Viewport_8295813 branch December 19, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants