8296229: JFR: jfr tool should print unsigned values correctly

[egahlin]

Could I have a review of a PR that fixes so unsigned numbers are printed correctly in the jfr tool.

Testing:
test/jdk/jdk/jfr
test/jdk/jdk/security/logging/

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296229: JFR: jfr tool should print unsigned values correctly

Reviewers

• Sean Coffey (@coffeys - Reviewer)
• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11098/head:pull/11098
$ git checkout pull/11098

Update a local copy of the PR:
$ git checkout pull/11098
$ git pull https://git.openjdk.org/jdk pull/11098/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11098

View PR using the GUI difftool:
$ git pr show -t 11098

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11098.diff

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following labels will be automatically applied to this pull request:

• core-libs
• hotspot-jfr
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[egahlin]

/label remove security core-libs

[openjdk]

@egahlin
The security label was successfully removed.

The core-libs label was successfully removed.

[coffeys]

LGTM

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296229: JFR: jfr tool should print unsigned values correctly

Reviewed-by: coffeys, mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 4a30081: 8296747: com/sun/net/httpserver/simpleserver/StressDirListings.java timed out
• 12e76cb: 8296349: [aarch64] Avoid slicing Address::extend
• 7244eac: 8296771: RISC-V: C2: assert(false) failed: bad AD file
• 956d75b: 8295099: vmTestbase/nsk/stress/strace/strace013.java failed with "TestFailure: wrong lengths of stack traces: strace013Thread0: NNN strace013Thread83: MMM"
• 2f9a94f: 8296824: ProblemList compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java
• 43ebd96: 8296822: ProblemList jdk/jfr/api/consumer/TestRecordingFileWrite.java
• 84e1224: 8296496: Overzealous check in sizecalc.h prevents large memory allocation
• 27527b4: 8296612: CertAttrSet is useless
• 6b456f7: 8262901: [macos_aarch64] NativeCallTest expected:<-3.8194101E18> but was:<3.02668882E10>
• e1badb7: 8295871: G1: Use different explicit claim marks for CLDs
• ... and 3 more: https://git.openjdk.org/jdk/compare/4a68210d9f6c59ec4289b2e2412a1ae0df17fd81...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (f9710366)

[egahlin]

/integrate

[openjdk]

Going to push as commit 87b809a.
Since your change was applied there have been 17 commits pushed to the master branch:

• e7c2a8e: 8295214: Generational ZGC: Guard nmethods from cross modifying code
• d4d183e: 8296301: Interpreter(RISC-V): Implement -XX:+PrintBytecodeHistogram and -XX:+PrintBytecodePairHistogram options
• f754840: 8296773: G1: Factor out hash function for G1CardSet
• fdabd37: 8293696: java/nio/channels/DatagramChannel/SelectWhenRefused.java fails with "Unexpected wakeup"
• 4a30081: 8296747: com/sun/net/httpserver/simpleserver/StressDirListings.java timed out
• 12e76cb: 8296349: [aarch64] Avoid slicing Address::extend
• 7244eac: 8296771: RISC-V: C2: assert(false) failed: bad AD file
• 956d75b: 8295099: vmTestbase/nsk/stress/strace/strace013.java failed with "TestFailure: wrong lengths of stack traces: strace013Thread0: NNN strace013Thread83: MMM"
• 2f9a94f: 8296824: ProblemList compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java
• 43ebd96: 8296822: ProblemList jdk/jfr/api/consumer/TestRecordingFileWrite.java
• ... and 7 more: https://git.openjdk.org/jdk/compare/4a68210d9f6c59ec4289b2e2412a1ae0df17fd81...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit 87b809a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.