Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253008: Remove develop flags TraceLongCompiles/LongCompileThreshold #111

Closed
wants to merge 2 commits into from

Conversation

@robehn
Copy link
Contributor

@robehn robehn commented Sep 10, 2020

These flags make little sense.
They measure non safepointing VM ops, that's only handshake now.
Which have little relation to compiles.

Builds runs locally, running T1 now.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253008: Remove develop flags TraceLongCompiles/LongCompileThreshold

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/111/head:pull/111
$ git checkout pull/111

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 10, 2020

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 10, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2020

@robehn The following label will be automatically applied to this pull request: hotspot-runtime.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 10, 2020

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2020

@robehn This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253008: Remove develop flags TraceLongCompiles/LongCompileThreshold

Reviewed-by: shade, dholmes, adityam
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • c7062dc: 8253026: Remove dummy call to gc alot from VM Thread

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate c7062dc22bc7c14cac730144b352f8b64f5b71d1.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 10, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 10, 2020

Mailing list message from David Holmes on hotspot-runtime-dev:

Hi Robbin,

On 10/09/2020 10:21 pm, Robbin Ehn wrote:

These flags make little sense.
They measure non safepointing VM ops, that's only handshake now.
Which have little relation to compiles.

As this predates handshakes, what non-safepoint VMoperations would be
measured here? I checked the code back to 6u10 and there are zero
non-safepoint VMops. So this is basically long dead code.

Cheers,
David
-----

Loading

@robehn
Copy link
Contributor Author

@robehn robehn commented Sep 10, 2020

Thanks @shipilev and @dholmes-ora.
And thanks for the digging!

Loading

@robehn
Copy link
Contributor Author

@robehn robehn commented Sep 11, 2020

Thanks @adityamandaleeka!

Conflict was trivial, build locally after merge, integrating now.

Loading

@robehn
Copy link
Contributor Author

@robehn robehn commented Sep 11, 2020

/integrate

Loading

@openjdk openjdk bot closed this Sep 11, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 11, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 11, 2020

@robehn Since your change was applied there has been 1 commit pushed to the master branch:

  • c7062dc: 8253026: Remove dummy call to gc alot from VM Thread

Your commit was automatically rebased without conflicts.

Pushed as commit 8777ded.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@robehn robehn deleted the 8253008-long-compile-flags branch Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants