Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294033: x86_64: libm stubs are missing #11100

Closed
wants to merge 1 commit into from

Conversation

iwanowww
Copy link
Contributor

@iwanowww iwanowww commented Nov 11, 2022

There's a regression from JDK-8293285 refactoring where I forgot to call generate_libm_stubs() during stub initialization phase.

The patch restores proper stub init sequence and also piles some minor refactorings on top.

Testing: hs-tier1 - hs-tier2

Thanks!

/cc hotspot


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11100/head:pull/11100
$ git checkout pull/11100

Update a local copy of the PR:
$ git checkout pull/11100
$ git pull https://git.openjdk.org/jdk pull/11100/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11100

View PR using the GUI difftool:
$ git pr show -t 11100

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11100.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 11, 2022

👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Nov 11, 2022
@openjdk
Copy link

openjdk bot commented Nov 11, 2022

@iwanowww
The hotspot label was successfully added.

@iwanowww iwanowww marked this pull request as ready for review November 11, 2022 02:19
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 11, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 11, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 11, 2022

@iwanowww This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294033: x86_64: libm stubs are missing

Reviewed-by: jvernee, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 956d75b: 8295099: vmTestbase/nsk/stress/strace/strace013.java failed with "TestFailure: wrong lengths of stack traces: strace013Thread0: NNN strace013Thread83: MMM"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 11, 2022
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@iwanowww
Copy link
Contributor Author

Thanks for the reviews, Jorn and Vladimir.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 11, 2022

Going to push as commit 34a499d.
Since your change was applied there have been 13 commits pushed to the master branch:

  • f0b648b: 8296758: [BACKOUT] Revert 8296115
  • 7f587e5: 8296872: gtest is built with the build-jdk
  • 819c691: 8295867: TestVerifyGraphEdges.java fails with exit code -1073741571 when using AlwaysIncrementalInline
  • ced88a2: 8296733: JFR: File Read event for RandomAccessFile::write(byte[]) is incorrect
  • 87b809a: 8296229: JFR: jfr tool should print unsigned values correctly
  • e7c2a8e: 8295214: Generational ZGC: Guard nmethods from cross modifying code
  • d4d183e: 8296301: Interpreter(RISC-V): Implement -XX:+PrintBytecodeHistogram and -XX:+PrintBytecodePairHistogram options
  • f754840: 8296773: G1: Factor out hash function for G1CardSet
  • fdabd37: 8293696: java/nio/channels/DatagramChannel/SelectWhenRefused.java fails with "Unexpected wakeup"
  • 4a30081: 8296747: com/sun/net/httpserver/simpleserver/StressDirListings.java timed out
  • ... and 3 more: https://git.openjdk.org/jdk/compare/2f9a94f41c1b5ea38efa8ee6dd71f0b6db401028...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 11, 2022
@openjdk openjdk bot closed this Nov 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 11, 2022
@openjdk
Copy link

openjdk bot commented Nov 11, 2022

@iwanowww Pushed as commit 34a499d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants