-
Notifications
You must be signed in to change notification settings - Fork 6.2k
JDK-8292594: Use CSS custom properties for all fonts and colors #11109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into |
jonathan-gibbons
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's really nice to see those hex constants disappearing from being spread out through the stylesheet.
|
@hns This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 251 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 361b50e.
Your commit was automatically rebased without conflicts. |
Please review a patch to complete the conversion of the javadoc style sheet to use CSS custom properties for all colors and fonts.
A few notes for changes that may not be self-explanatory:
--highlightproperty prefix used for the active navigation/menu/tab item to--selectedas the term "highlight" is used for other things such as snippet highlights and active search item targets.-linksourceoption. This is a very rarely used option so I chose to use a custom property with no defined value but a default value. This means the custom property is not contained in the list of custom property definitions in the style sheet, but it can be defined by a theme if needed.This change does not affect the appearance of the generated documentation in the browser. I can provide before/after output including different themes if needed.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11109/head:pull/11109$ git checkout pull/11109Update a local copy of the PR:
$ git checkout pull/11109$ git pull https://git.openjdk.org/jdk pull/11109/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11109View PR using the GUI difftool:
$ git pr show -t 11109Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11109.diff