8296900: CertificateValidity fields are not optional

[wangweij]

Make two fields inside CertificateValidity final.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296900: CertificateValidity fields are not optional

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11126/head:pull/11126
$ git checkout pull/11126

Update a local copy of the PR:
$ git checkout pull/11126
$ git pull https://git.openjdk.org/jdk pull/11126/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11126

View PR using the GUI difftool:
$ git pr show -t 11126

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11126.diff

[bridgekeeper]

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wangweij The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3266a7ec)

[mcpowers]

The changes look good to me.

[seanjmullan]

Typo in bug summary, change to "CertificateValidity fields are not optional"

[openjdk]

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296900: CertificateValidity fields are not optional

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• 8c472e4: 8294217: Assertion failure: parsing found no loops but there are some
• 0fe2bf5: 8296805: ctw build is broken
• e1d298c: 8296741: Illegal X400Address and EDIPartyName should not be created
• b0edfc1: 8164464: Consistent failure of java/awt/dnd/MissingEventsOnModalDialog/MissingEventsOnModalDialogTest.java
• 9c39932: 8294899: Process.waitFor() throws IllegalThreadStateException when a process on Windows returns an exit code of 259
• 3f401b3: 8296670: G1: Remove unused G1GCPhaseTimes::record_preserve_cm_referents_time_ms
• 68301cd: 8296665: IGV: Show dialog with stack trace for exceptions
• 277f0c2: 8296821: compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java fails after JDK-8262901
• 34d10f1: 8296243: [IR Framework] Fix issues with IRNode.ALLOC* regexes
• 8eb90e2: 8296797: java/nio/channels/vthread/BlockingChannelOps.testSocketChannelWriteAsyncClose failed with ClosedChannelException
• ... and 20 more: https://git.openjdk.org/jdk/compare/27527b49752110fcfca285a1b6dd995d5d103fe5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[wangweij]

/integrate

[wangweij]

/integrate

[openjdk]

Going to push as commit a7c2338.
Since your change was applied there have been 34 commits pushed to the master branch:

• 3eb789a: 8296171: Compiler incorrectly rejects code with variadic method references
• 749335d: 8291911: java/io/File/GetXSpace.java fails with "53687091200 != 161051996160"
• 95b8405: 8296431: PushbackInputStream should override transferTo
• e269dc0: 8293681: ResponseAPDU getData() method javadoc
• 8c472e4: 8294217: Assertion failure: parsing found no loops but there are some
• 0fe2bf5: 8296805: ctw build is broken
• e1d298c: 8296741: Illegal X400Address and EDIPartyName should not be created
• b0edfc1: 8164464: Consistent failure of java/awt/dnd/MissingEventsOnModalDialog/MissingEventsOnModalDialogTest.java
• 9c39932: 8294899: Process.waitFor() throws IllegalThreadStateException when a process on Windows returns an exit code of 259
• 3f401b3: 8296670: G1: Remove unused G1GCPhaseTimes::record_preserve_cm_referents_time_ms
• ... and 24 more: https://git.openjdk.org/jdk/compare/27527b49752110fcfca285a1b6dd995d5d103fe5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wangweij Pushed as commit a7c2338.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[openjdk]

@wangweij The command integrate can only be used in open pull requests.