-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8193547: Regression automated test '/open/test/jdk/java/awt/Toolkit/DesktopProperties/rfe4758438.java' fails #11127
Conversation
👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into |
Ping? |
@azvegint this pull request can not be integrated into git checkout testsprint_rfe4758438
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
@azvegint This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit c05dbac.
Your commit was automatically rebased without conflicts. |
This test has multiple issues:
pgrep gnome-session
may return multiple PIDs -> picking up only first oneXDG_CURRENT_DESKTOP
insteadorg.gnome.settings-daemon.peripherals.mouse
is deprecated and does not work on latest systemsbut newer
org.gnome.desktop.peripherals.mouse
works as expectedSo the test modified to try new one and to check deprecated as a fallback
CI testing looks good.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11127/head:pull/11127
$ git checkout pull/11127
Update a local copy of the PR:
$ git checkout pull/11127
$ git pull https://git.openjdk.org/jdk pull/11127/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11127
View PR using the GUI difftool:
$ git pr show -t 11127
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11127.diff