Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8193547: Regression automated test '/open/test/jdk/java/awt/Toolkit/DesktopProperties/rfe4758438.java' fails #11127

Closed
wants to merge 3 commits into from

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Nov 14, 2022

This test has multiple issues:

  • Test actually does nothing and passes as it is right now, but tests nothing
  • pgrep gnome-session may return multiple PIDs -> picking up only first one
  • looks like jtreg does not pass GNOME_DESKTOP_SESSION_ID variable(it is deprecated, BTW), so used XDG_CURRENT_DESKTOP instead
  • removed leftovers from Solaris support
  • org.gnome.settings-daemon.peripherals.mouse is deprecated and does not work on latest systems
    but newer org.gnome.desktop.peripherals.mouse works as expected
    So the test modified to try new one and to check deprecated as a fallback

CI testing looks good.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8193547: Regression automated test '/open/test/jdk/java/awt/Toolkit/DesktopProperties/rfe4758438.java' fails

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11127/head:pull/11127
$ git checkout pull/11127

Update a local copy of the PR:
$ git checkout pull/11127
$ git pull https://git.openjdk.org/jdk pull/11127/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11127

View PR using the GUI difftool:
$ git pr show -t 11127

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11127.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2022

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 14, 2022

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 14, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 14, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 14, 2022

Webrevs

@azvegint
Copy link
Member Author

azvegint commented Dec 5, 2022

Ping?

@openjdk
Copy link

openjdk bot commented Dec 11, 2022

@azvegint this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout testsprint_rfe4758438
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Dec 11, 2022
@openjdk
Copy link

openjdk bot commented Dec 12, 2022

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8193547: Regression automated test '/open/test/jdk/java/awt/Toolkit/DesktopProperties/rfe4758438.java' fails

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • fabda24: 8296389: C2: PhaseCFG::convert_NeverBranch_to_Goto must handle both orders of successors

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed merge-conflict Pull request has merge conflict with target branch labels Dec 12, 2022
@azvegint
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 14, 2022

Going to push as commit c05dbac.
Since your change was applied there have been 33 commits pushed to the master branch:

  • 0dce5b8: 8296610: java/net/HttpURLConnection/SetAuthenticator/HTTPSetAuthenticatorTest.java failed with "BindException: Address already in use: connect"
  • ed8a212: 8298376: ZGC: thaws stackChunk with stale oops
  • 2e801e1: 8298475: Remove JVM_ACC_PROMOTED_FLAGS
  • 9ee5037: 8298636: Fix return value in WB_CountAliveClasses and WB_GetSymbolRefcount
  • ceca4fc: 8298264: Merge OffsetTableContigSpace into TenuredSpace
  • d32d6c0: 8297791: update _max_classes in node type system
  • b754aa5: 8298371: monitors_on_stack extracts unprocessed oops
  • 220781f: 8298513: vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy009/TestDescription.java fails with usage tracker
  • a120764: 8298514: vmTestbase/nsk/jdi/EventRequestManager/threadDeathRequests/thrdeathreq002/TestDescription.java fails with usage tracker
  • 6802277: 8298524: Debug function to trace reachability of CDS archived heap objects
  • ... and 23 more: https://git.openjdk.org/jdk/compare/6c23b4fd0d7883bdcdf20438c21fe226c8de19f5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 14, 2022
@openjdk openjdk bot closed this Dec 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 14, 2022
@openjdk
Copy link

openjdk bot commented Dec 14, 2022

@azvegint Pushed as commit c05dbac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants