Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296786: Limit VM modes for com/sun/jdi/JdbLastErrorTest.java #11136

Closed

Conversation

kevinjwalls
Copy link
Contributor

@kevinjwalls kevinjwalls commented Nov 14, 2022

This is a (trivial) change of the @requires statement in a test:
don't run in -Xcomp or -Xint modes, where the interaction of Windows' native GetLastError and Panama direct native access are known not to work well together.

Remove test/jdk/ProblemList-Xcomp.txt entry for this test.

Running jtreg directly (which would ignore problemlist) will now skip this test if e.g. those modes are given using -vmoption


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296786: Limit VM modes for com/sun/jdi/JdbLastErrorTest.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11136/head:pull/11136
$ git checkout pull/11136

Update a local copy of the PR:
$ git checkout pull/11136
$ git pull https://git.openjdk.org/jdk pull/11136/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11136

View PR using the GUI difftool:
$ git pr show -t 11136

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11136.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2022

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 14, 2022
@openjdk
Copy link

openjdk bot commented Nov 14, 2022

@kevinjwalls The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Nov 14, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 14, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 14, 2022

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296786: Limit VM modes for com/sun/jdi/JdbLastErrorTest.java

Reviewed-by: cjplummer, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 2f7dc5c: 8296089: Remove debug agent code for special handling of Thread.resume()
  • c71d87e: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3
  • a7c2338: 8296900: CertificateValidity fields are not optional
  • 3eb789a: 8296171: Compiler incorrectly rejects code with variadic method references
  • 749335d: 8291911: java/io/File/GetXSpace.java fails with "53687091200 != 161051996160"
  • 95b8405: 8296431: PushbackInputStream should override transferTo
  • e269dc0: 8293681: ResponseAPDU getData() method javadoc
  • 8c472e4: 8294217: Assertion failure: parsing found no loops but there are some
  • 0fe2bf5: 8296805: ctw build is broken
  • e1d298c: 8296741: Illegal X400Address and EDIPartyName should not be created
  • ... and 2 more: https://git.openjdk.org/jdk/compare/3f401b309124eecef7a39aac663bb5e8808a4476...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 14, 2022
Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little odd that 8293829 was closed as "will not fix"
and this new bug is used to remove the entry for 8293829.
I can see the desire to make this change clean and clear
and not get tied up in the history and discussion of 8293829.

Thumbs up.

@dcubed-ojdk
Copy link
Member

Also heads up that there is another fix coming for the same test:
JDK-8296913 Correct enable preview idiom in JdbLastErrorTest.java

@kevinjwalls
Copy link
Contributor Author

Thanks for the reviews, I'll integrate this and hope we work things out with the other concurrent review on this file!

@kevinjwalls
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 15, 2022

Going to push as commit 8a9eabb.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 873eccd: 8296923: JFR: jfr --version should return System.getProperty("java version")
  • 93d6b1f: 8295711: Rename ZBarrierSetAssembler::load_at parameter name from "tmp_thread" to "tmp2"
  • 2f7dc5c: 8296089: Remove debug agent code for special handling of Thread.resume()
  • c71d87e: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3
  • a7c2338: 8296900: CertificateValidity fields are not optional
  • 3eb789a: 8296171: Compiler incorrectly rejects code with variadic method references
  • 749335d: 8291911: java/io/File/GetXSpace.java fails with "53687091200 != 161051996160"
  • 95b8405: 8296431: PushbackInputStream should override transferTo
  • e269dc0: 8293681: ResponseAPDU getData() method javadoc
  • 8c472e4: 8294217: Assertion failure: parsing found no loops but there are some
  • ... and 4 more: https://git.openjdk.org/jdk/compare/3f401b309124eecef7a39aac663bb5e8808a4476...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 15, 2022
@openjdk openjdk bot closed this Nov 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 15, 2022
@openjdk
Copy link

openjdk bot commented Nov 15, 2022

@kevinjwalls Pushed as commit 8a9eabb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants