Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8296619: Upgrade jQuery to 3.6.1 #11138

Closed
wants to merge 1 commit into from
Closed

Conversation

hns
Copy link
Member

@hns hns commented Nov 14, 2022

Please review a change to upgrade the jQuery JS library used by javadoc from 3.6.0 to 3.6.1. The files (uncompressed and compressed) were obtained from https://jquery.com/download/.

I tested the generated API documentation in the browsers and ran the test suite including the manual TestSearchScript test.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11138/head:pull/11138
$ git checkout pull/11138

Update a local copy of the PR:
$ git checkout pull/11138
$ git pull https://git.openjdk.org/jdk pull/11138/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11138

View PR using the GUI difftool:
$ git pr show -t 11138

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11138.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2022

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 14, 2022
@openjdk
Copy link

openjdk bot commented Nov 14, 2022

@hns The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label Nov 14, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 14, 2022

Webrevs

@hns hns changed the title JDK-8296619: Upgrade jQuery from 3.6.0 to 3.6.1 JDK-8296619: Upgrade jQuery to 3.6.1 Dec 5, 2022
@openjdk
Copy link

openjdk bot commented Dec 5, 2022

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296619: Upgrade jQuery to 3.6.1

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 368 new commits pushed to the master branch:

  • a38c63d: 8297733: Refactor Cast binding to enum
  • 19d8498: 8297495: j.u.concurrent updates for JDK 20
  • 3288459: 8297606: [AIX] Broken build after JDK-8295475
  • 0452c39: 8296477: Foreign linker implementation update following JEP 434
  • 73baadc: 8295044: Implementation of Foreign Function and Memory API (Second Preview)
  • bd38188: 8297766: Remove UseMallocOnly development option
  • b9eec96: 8281214: Unsafe use of long in VMThread::setup_periodic_safepoint_if_needed
  • e7e0354: 8297767: Assert JNICritical_lock/safepoint-1 and AdapterHandlerLibrary_lock/safepoint-1
  • f9e0f1d: 8297763: Fix missing stub code expansion before align() in shared trampolines
  • 2300ed4: 8291769: Translation of switch with record patterns could be improved
  • ... and 358 more: https://git.openjdk.org/jdk/compare/3f401b309124eecef7a39aac663bb5e8808a4476...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 5, 2022
@hns
Copy link
Member Author

hns commented Dec 5, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 5, 2022

Going to push as commit 6a7a0db.
Since your change was applied there have been 368 commits pushed to the master branch:

  • a38c63d: 8297733: Refactor Cast binding to enum
  • 19d8498: 8297495: j.u.concurrent updates for JDK 20
  • 3288459: 8297606: [AIX] Broken build after JDK-8295475
  • 0452c39: 8296477: Foreign linker implementation update following JEP 434
  • 73baadc: 8295044: Implementation of Foreign Function and Memory API (Second Preview)
  • bd38188: 8297766: Remove UseMallocOnly development option
  • b9eec96: 8281214: Unsafe use of long in VMThread::setup_periodic_safepoint_if_needed
  • e7e0354: 8297767: Assert JNICritical_lock/safepoint-1 and AdapterHandlerLibrary_lock/safepoint-1
  • f9e0f1d: 8297763: Fix missing stub code expansion before align() in shared trampolines
  • 2300ed4: 8291769: Translation of switch with record patterns could be improved
  • ... and 358 more: https://git.openjdk.org/jdk/compare/3f401b309124eecef7a39aac663bb5e8808a4476...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 5, 2022
@openjdk openjdk bot closed this Dec 5, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 5, 2022
@openjdk
Copy link

openjdk bot commented Dec 5, 2022

@hns Pushed as commit 6a7a0db.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants