JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java

[jddarcy]

Update the compile command in JdbLastErrorTest.java so that it doesn't need to be modified with each new JDK release to keep using preview features.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java

Reviewers

• Chris Plummer (@plummercj - Reviewer) ⚠️ Review applies to 7a8d00b4
• Kevin Walls (@kevinjwalls - Committer) ⚠️ Review applies to 7a8d00b4
• Alan Bateman (@AlanBateman - Reviewer) ⚠️ Review applies to 7a8d00b4
• Serguei Spitsyn (@sspitsyn - Reviewer) ⚠️ Review applies to 7a8d00b4

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11139/head:pull/11139
$ git checkout pull/11139

Update a local copy of the PR:
$ git checkout pull/11139
$ git pull https://git.openjdk.org/jdk pull/11139/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11139

View PR using the GUI difftool:
$ git pr show -t 11139

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11139.diff

[bridgekeeper]

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jddarcy The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (86f11dc2)
• 02: Full - Incremental (7a8d00b4)
• 01: Full - Incremental (0e7972b8)
• 00: Full (db01da1d)

[AlanBateman]

Better still would be to add @enablePreview. That would allow the @run compile line to go away and you can drop the --enable-preview from the @run main.

[jddarcy]

Is that a new jtreg feature? I've used the idiom in the updated version of this file elsewhere in the JDK.

[AlanBateman]

https://bugs.openjdk.org/browse/CODETOOLS-7902654
I only became aware of it a few months ago.

[jddarcy]

Thanks @AlanBateman; I wasn't aware of the feature. Looks like there is still usage of the old idiom.

[openjdk]

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296913: Correct enable preview idiom in JdbLastErrorTest.java

Reviewed-by: cjplummer, kevinw, alanb, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kevinjwalls]

Looks good. I was thinking it would need an update to remove the preview option in the future, but this is even better, and didn't occur to me at the time, thanks!

Hopefully my other change in the same file just now, on the requires line, doesn't conflict and cause a problem.

[jddarcy]

/integrate

[openjdk]

Going to push as commit 87530e6.

[openjdk]

@jddarcy Pushed as commit 87530e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.