7132279: (ch) SeekableByteChannel operation may throw Non{Readable,Writable}ChannelException

[bplb]

Fix the specifications of the read and write methods in SeekableByteChannel and FileChannel to indicate that a NonReadableChannelException or NonWritableChannelException, respectively.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires a CSR request to be approved

Issues

• JDK-7132279: (ch) SeekableByteChannel operation may throw Non{Readable,Writable}ChannelException
• JDK-8297054: (ch) SeekableByteChannel operation may throw Non{Readable,Writable}ChannelException (CSR)

Reviewers

• Lance Andersen (@LanceAndersen - Reviewer)
• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11141/head:pull/11141
$ git checkout pull/11141

Update a local copy of the PR:
$ git checkout pull/11141
$ git pull https://git.openjdk.org/jdk pull/11141/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11141

View PR using the GUI difftool:
$ git pr show -t 11141

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11141.diff

[bplb]

There is no behavioral change.

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (dbdfb90e)

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7132279: (ch) SeekableByteChannel operation may throw Non{Readable,Writable}ChannelException

Reviewed-by: lancea, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• 0cbf084: 8296969: C1: PrintC1Statistics is broken after JDK-8292878
• f662a06: 8296970: Remove sysThreadAvailableStackWithSlack from hotspot-symbols
• 7357a1a: 8296889: Race condition when cancelling a request
• 87530e6: 8296913: Correct enable preview idiom in JdbLastErrorTest.java
• fafe682: 8295861: get rid of list argument in debug agent's removeNode() API
• 216c6f6: 8294881: test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003/TestDescription.java fails
• 6aef3a4: 8262435: Clarify the behavior of a few inherited ZipInputStream methods
• c042b8e: 8294731: Improve multiplicative inverse for secp256r1 implementation
• d3051a7: 8296736: Some PKCS9Attribute can be created but cannot be encoded
• decb1b7: 8286800: Assert in PhaseIdealLoop::dump_real_LCA is too strong
• ... and 13 more: https://git.openjdk.org/jdk/compare/3eb789af74231d37796a5670ffab935cabbf3b09...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

/integrate

[openjdk]

Going to push as commit b97fc93.
Since your change was applied there have been 44 commits pushed to the master branch:

• 39dda24: 8157173: [macosx] java/awt/Robot/ModifierRobotKey/ModifierRobotKeyTest.java fails
• 51f690d: 8297134: Add a @sealedGraph tag to InetAddress
• 3eb6d0e: 8291991: Adjust the "shared class paths mismatch" message if class path logging is enabled
• eac26f4: 8296709: WARNING: JNI call made without checking exceptions
• 4946737: 8297047: IGV: graphContent not set when opening a new tab
• 8b1ff9e: 8297132: BACKOUT JDK-8296889: Race condition when cancelling a request
• e72b0ac: 8296429: Remove os::supports_sse
• 813b223: 8296926: Sort include lines of files in the include/ directory
• 8cdcec4: 8296774: Removed default MEMFLAGS value from CHeapBitMap
• c3b285a: 8296916: RISC-V: Move some small macro-assembler functions to header file
• ... and 34 more: https://git.openjdk.org/jdk/compare/3eb789af74231d37796a5670ffab935cabbf3b09...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit b97fc93.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.