Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296754: AutoCreateSharedArchive in JDK 20 is not compatible with JDK 19 #11148

Closed

Conversation

matias9927
Copy link
Contributor

@matias9927 matias9927 commented Nov 14, 2022

The -XX:+AutoCreateSharedArchive flag was implemented in JDK 19, however, this flag doesn't work across JDK 19 and 20.

Expected: JDK 20 should recreate the specified CDS archive
Actual: JDK 20 cannot recognize the archive file and gives up

The new field from GenericCDSFileMapHeader is now in FileMapHeader. Verified with tier 1-4 tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296754: AutoCreateSharedArchive in JDK 20 is not compatible with JDK 19

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11148/head:pull/11148
$ git checkout pull/11148

Update a local copy of the PR:
$ git checkout pull/11148
$ git pull https://git.openjdk.org/jdk pull/11148/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11148

View PR using the GUI difftool:
$ git pr show -t 11148

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11148.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2022

👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 14, 2022

@matias9927 The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Nov 14, 2022
@matias9927 matias9927 marked this pull request as ready for review November 15, 2022 17:41
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 15, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 15, 2022

Webrevs

Copy link
Member

@calvinccheung calvinccheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just couple of nits.

src/hotspot/share/cds/cdsConstants.cpp Outdated Show resolved Hide resolved
@openjdk
Copy link

openjdk bot commented Nov 15, 2022

@matias9927 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296754: AutoCreateSharedArchive in JDK 20 is not compatible with JDK 19

Reviewed-by: ccheung, iklam, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

  • ba0a252: 8297717: Remove jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java from ProblemList
  • c05dc80: 8297660: x86: Redundant test+jump in C1 allocateArray
  • eff4c03: 8297343: TestStress*.java fail with "got different traces for the same seed"
  • 6a856bc: 8297499: Parallel: Missing iteration over klass when marking objArrays/objArrayOops during Full GC
  • b80f5af: 8297309: Memory leak in ShenandoahFullGC
  • 81eb5fb: 8297534: Specify the size of MEMFLAGS
  • 012dafe: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list
  • 43d1173: 8286302: Port JEP 425 to PPC64
  • d610211: 8297408: Consolidate code in runtime/ErrorHandling
  • 2f83b5c: 8297640: Increase buffer size for buf (insert_features_names) in Abstract_VM_Version::insert_features_names
  • ... and 54 more: https://git.openjdk.org/jdk/compare/260e4dcbfd8bdccdf332c2b6a07990cd14f6bcfb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@calvinccheung, @iklam, @erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 15, 2022
@iklam
Copy link
Member

iklam commented Nov 16, 2022

/label add build-dev

Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some minor nits for the test.

@openjdk openjdk bot added the build build-dev@openjdk.org label Nov 16, 2022
@openjdk
Copy link

openjdk bot commented Nov 16, 2022

@iklam
The build label was successfully added.

Copy link
Member

@erikj79 erikj79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makefile change looks good.

Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matias9927
Copy link
Contributor Author

matias9927 commented Nov 22, 2022

Thank you for the feedback Erik, Calvin, and Ioi!
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 22, 2022
@openjdk
Copy link

openjdk bot commented Nov 22, 2022

@matias9927
Your change (at version 718b4f6) is now ready to be sponsored by a Committer.

@matias9927 matias9927 force-pushed the autoCreateSharedArchive_8296754 branch from 718b4f6 to 66b0394 Compare November 22, 2022 17:40
@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Nov 22, 2022
@openjdk-notifier
Copy link

@matias9927 Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

@matias9927 matias9927 force-pushed the autoCreateSharedArchive_8296754 branch from 66b0394 to 0d01844 Compare November 22, 2022 19:17
@openjdk-notifier
Copy link

@matias9927 Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved latest changes again. Matias had to do second force-push which reverted the effects of the first force-push.

@matias9927
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 28, 2022
@openjdk
Copy link

openjdk bot commented Nov 28, 2022

@matias9927
Your change (at version 0d01844) is now ready to be sponsored by a Committer.

@iklam
Copy link
Member

iklam commented Nov 28, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 28, 2022

Going to push as commit a249a52.
Since your change was applied there have been 65 commits pushed to the master branch:

  • 405b188: 8297570: jdk/jfr/threading/TestDeepVirtualStackTrace.java fails with -XX:-UseTLAB
  • ba0a252: 8297717: Remove jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java from ProblemList
  • c05dc80: 8297660: x86: Redundant test+jump in C1 allocateArray
  • eff4c03: 8297343: TestStress*.java fail with "got different traces for the same seed"
  • 6a856bc: 8297499: Parallel: Missing iteration over klass when marking objArrays/objArrayOops during Full GC
  • b80f5af: 8297309: Memory leak in ShenandoahFullGC
  • 81eb5fb: 8297534: Specify the size of MEMFLAGS
  • 012dafe: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list
  • 43d1173: 8286302: Port JEP 425 to PPC64
  • d610211: 8297408: Consolidate code in runtime/ErrorHandling
  • ... and 55 more: https://git.openjdk.org/jdk/compare/260e4dcbfd8bdccdf332c2b6a07990cd14f6bcfb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 28, 2022
@openjdk openjdk bot closed this Nov 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 28, 2022
@openjdk
Copy link

openjdk bot commented Nov 28, 2022

@iklam @matias9927 Pushed as commit a249a52.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
4 participants