8297020: Rename GrowableArray::on_stack

[stefank]

GrowableArray::on_stack is confusing. It returns true if the backing elements are allocated in the stack's resource area. We typically call this resource allocations, not stack allocations. I propose that we rename it.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8297020: Rename GrowableArray::on_stack

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer)
• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11161/head:pull/11161
$ git checkout pull/11161

Update a local copy of the PR:
$ git checkout pull/11161
$ git pull https://git.openjdk.org/jdk pull/11161/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11161

View PR using the GUI difftool:
$ git pr show -t 11161

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11161.diff

[stefank]

/label add hotspot

[bridgekeeper]

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into pr/11086 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@stefank
The hotspot label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (c16e0336)
• 00: Full (c16e0336)

[tstuefe]

+1

[coleenp]

Yes, looks good.

[stefank]

Thanks for the reviews!

[tstuefe]

Thanks for the reviews!

Thanks for doing all this!

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8297020_rename_growablearray_on_stack
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@stefank This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297020: Rename GrowableArray::on_stack

Reviewed-by: stuefe, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• 5f51dff: 8296776: Stop using mtNone as marker for CHeap allocations in GrowableArray
• 499406c: 8285488: Improve DocFinder
• 97ab2c3: 8296953: Fix a typo in exception documentation
• 5e08b3f: 8296931: NMT tests slowed down considerably by JDK-8242181
• 65f7de2: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails
• 3f2f128: 8295952: Problemlist existing compiler/rtm tests also on x86
• 6ead2b0: 8296548: Improve MD5 intrinsic for x86_64
• bd3acbe: 8297089: [BACKOUT] JDK-8297088 Update LCMS to 2.14
• 6a60d31: 8295369: Update LCMS to 2.14
• 0cbf084: 8296969: C1: PrintC1Statistics is broken after JDK-8292878
• ... and 15 more: https://git.openjdk.org/jdk/compare/5551cb66ba58cadce7291a95c5af662ade2cb7b8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[stefank]

/integrate

[openjdk]

Going to push as commit 196d021.
Since your change was applied there have been 25 commits pushed to the master branch:

• 5f51dff: 8296776: Stop using mtNone as marker for CHeap allocations in GrowableArray
• 499406c: 8285488: Improve DocFinder
• 97ab2c3: 8296953: Fix a typo in exception documentation
• 5e08b3f: 8296931: NMT tests slowed down considerably by JDK-8242181
• 65f7de2: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails
• 3f2f128: 8295952: Problemlist existing compiler/rtm tests also on x86
• 6ead2b0: 8296548: Improve MD5 intrinsic for x86_64
• bd3acbe: 8297089: [BACKOUT] JDK-8297088 Update LCMS to 2.14
• 6a60d31: 8295369: Update LCMS to 2.14
• 0cbf084: 8296969: C1: PrintC1Statistics is broken after JDK-8292878
• ... and 15 more: https://git.openjdk.org/jdk/compare/5551cb66ba58cadce7291a95c5af662ade2cb7b8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@stefank Pushed as commit 196d021.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.