8297006: JFR: AbstractEventStream should not hold thread instance

[egahlin]

Could I have a review of a PR that removes an unnecessary reference to a thread. This could potentially become a memory leak.

Testing: test/jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8297006: JFR: AbstractEventStream should not hold thread instance

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11166/head:pull/11166
$ git checkout pull/11166

Update a local copy of the PR:
$ git checkout pull/11166
$ git pull https://git.openjdk.org/jdk pull/11166/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11166

View PR using the GUI difftool:
$ git pr show -t 11166

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11166.diff

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d07c728f)

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297006: JFR: AbstractEventStream should not hold thread instance

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• 8cdcec4: 8296774: Removed default MEMFLAGS value from CHeapBitMap
• c3b285a: 8296916: RISC-V: Move some small macro-assembler functions to header file
• 720c3d0: 8296932: G1: Remove unused G1RootClosures::weak_oops
• 196d021: 8297020: Rename GrowableArray::on_stack
• 5f51dff: 8296776: Stop using mtNone as marker for CHeap allocations in GrowableArray
• 499406c: 8285488: Improve DocFinder
• 97ab2c3: 8296953: Fix a typo in exception documentation
• 5e08b3f: 8296931: NMT tests slowed down considerably by JDK-8242181
• 65f7de2: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails
• 3f2f128: 8295952: Problemlist existing compiler/rtm tests also on x86
• ... and 17 more: https://git.openjdk.org/jdk/compare/9adb72837836c5cd67cd41af36aac3c07274f01b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit 04a4d34.
Since your change was applied there have been 40 commits pushed to the master branch:

• 5db1b58: 8296961: [JVMCI] Access to j.l.r.Method/Constructor/Field for ResolvedJavaMethod/ResolvedJavaField
• 4ce4f38: 8296958: [JVMCI] add API for retrieving ConstantValue attributes
• 8c26d02: 8295315: [REDO] 8276687 Remove support for JDK 1.4.1 PerfData shared memory files
• 8752bb4: 8296818: Enhance JMH tests java/security/Signatures.java
• b97fc93: 7132279: (ch) SeekableByteChannel operation may throw Non{Readable,Writable}ChannelException
• 39dda24: 8157173: [macosx] java/awt/Robot/ModifierRobotKey/ModifierRobotKeyTest.java fails
• 51f690d: 8297134: Add a @sealedGraph tag to InetAddress
• 3eb6d0e: 8291991: Adjust the "shared class paths mismatch" message if class path logging is enabled
• eac26f4: 8296709: WARNING: JNI call made without checking exceptions
• 4946737: 8297047: IGV: graphContent not set when opening a new tab
• ... and 30 more: https://git.openjdk.org/jdk/compare/9adb72837836c5cd67cd41af36aac3c07274f01b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit 04a4d34.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.