JDK-8297032: IGV: shortcut to center selected nodes

[tobiasholenstein]

Introduce a new shortcut CTRL-9/ CMD-9 to center the nodes that are currently selected in IGV

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8297032: IGV: shortcut to center selected nodes

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer) ⚠️ Review applies to 692a90bb
• Roberto Castañeda Lozano (@robcasloz - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11167/head:pull/11167
$ git checkout pull/11167

Update a local copy of the PR:
$ git checkout pull/11167
$ git pull https://git.openjdk.org/jdk pull/11167/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11167

View PR using the GUI difftool:
$ git pr show -t 11167

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11167.diff

[bridgekeeper]

👋 Welcome back tholenstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tobiasholenstein The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (1f275fbd)
• 00: Full (692a90bb)

[chhagedorn]

Works as expected on Linux - looks good!

[openjdk]

@tobiasholenstein This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297032: IGV: shortcut to center selected nodes

Reviewed-by: chagedorn, rcastanedalo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

• 4527dc6: 8297041: Remove the last remnants of sjavac
• 636040f: 8296405: java/util/concurrent/forkjoin/AsyncShutdownNow.java is too slow
• 2f728d0: 8295698: AArch64: test/jdk/sun/security/ec/ed/EdDSATest.java failed with -XX:+UseSHA3Intrinsics
• b9db16a: 8288717: Add a means to close idle connections in HTTP/2 connection pool
• 9f8b6d2: 8296437: NMT incurs costs if disabled
• e81359f: 8296170: Refactor stack-locking path in C2_MacroAssembler::fast_unlock()
• 502fa3e: 8296912: C2: CreateExNode::Identity fails with assert(i < _max) failed: oob: i=1, _max=1
• 5795c76: 8296222: SwingEventMonitor - installListeners(Component , int ) - CELLEDITOR - bug
• b9d6e83: 8296906: VMError::controlled_crash crashes with wrong code and address
• cd9c688: 8276064: CheckCastPP with raw oop input floats below a safepoint
• ... and 47 more: https://git.openjdk.org/jdk/compare/c49e48417d8e58dc34455cb5b503a1ba83a710aa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[robcasloz]

Looks good to me! A nit (up to you whether you want to address it in this PR): you might disable the action when no node is selected, similarly to the node extraction action.

[tobiasholenstein]

Looks good to me! A nit (up to you whether you want to address it in this PR): you might disable the action when no node is selected, similarly to the node extraction action.

Thanks for the good input @robcasloz !

I addressed your suggestion by making CenterSelectedNodesAction a ModelAwareAction and overriding the isEnabled() function: The action is now disabled if no nodes are selected

[robcasloz]

Thanks for addressing my suggestion, looks good!

[tobiasholenstein]

thanks @robcasloz and @chhagedorn for the reviews!

/integrate

[openjdk]

Going to push as commit d02bfdf.
Since your change was applied there have been 61 commits pushed to the master branch:

• 35acb89: 8296292: Document the default behavior of '$' in regular expressions correctly
• d8c809b: 8296492: Remove ObjectLocker in JVMTI get_subgroups call
• 171553a: 8297194: Add a @sealedGraph tag to Buffer
• bd57e21: 8296602: RISC-V: improve performance of copy_memory stub
• 4527dc6: 8297041: Remove the last remnants of sjavac
• 636040f: 8296405: java/util/concurrent/forkjoin/AsyncShutdownNow.java is too slow
• 2f728d0: 8295698: AArch64: test/jdk/sun/security/ec/ed/EdDSATest.java failed with -XX:+UseSHA3Intrinsics
• b9db16a: 8288717: Add a means to close idle connections in HTTP/2 connection pool
• 9f8b6d2: 8296437: NMT incurs costs if disabled
• e81359f: 8296170: Refactor stack-locking path in C2_MacroAssembler::fast_unlock()
• ... and 51 more: https://git.openjdk.org/jdk/compare/c49e48417d8e58dc34455cb5b503a1ba83a710aa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tobiasholenstein Pushed as commit d02bfdf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.