JDK-8297047: IGV: graphContent not set when opening a new tab

[tobiasholenstein]

Open any graph in IGV. The graph will be opened in a new tab as expected. But the tab has the name "graph" instead of the actual graph name. Further, the "Bytecode" and "Control Flow" windows are not updated with the current graph.

The reason was that graphContent was not set when opening a new EditorTopComponent.

Before:

Now the title of tab and the "Control Flow" is updated:

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8297047: IGV: graphContent not set when opening a new tab

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Roberto Castañeda Lozano (@robcasloz - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11168/head:pull/11168
$ git checkout pull/11168

Update a local copy of the PR:
$ git checkout pull/11168
$ git pull https://git.openjdk.org/jdk pull/11168/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11168

View PR using the GUI difftool:
$ git pr show -t 11168

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11168.diff

[bridgekeeper]

👋 Welcome back tholenstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tobiasholenstein The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1074ed9d)

[chhagedorn]

Looks good!

[openjdk]

@tobiasholenstein This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297047: IGV: graphContent not set when opening a new tab

Reviewed-by: chagedorn, rcastanedalo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 7357a1a: 8296889: Race condition when cancelling a request
• 87530e6: 8296913: Correct enable preview idiom in JdbLastErrorTest.java
• fafe682: 8295861: get rid of list argument in debug agent's removeNode() API
• 216c6f6: 8294881: test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003/TestDescription.java fails
• 6aef3a4: 8262435: Clarify the behavior of a few inherited ZipInputStream methods
• c042b8e: 8294731: Improve multiplicative inverse for secp256r1 implementation
• d3051a7: 8296736: Some PKCS9Attribute can be created but cannot be encoded
• decb1b7: 8286800: Assert in PhaseIdealLoop::dump_real_LCA is too strong

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[robcasloz]

Looks good.

[tobiasholenstein]

Thanks @chhagedorn and @robcasloz for the reviews!

/integrate

[openjdk]

Going to push as commit 4946737.
Since your change was applied there have been 26 commits pushed to the master branch:

• 8b1ff9e: 8297132: BACKOUT JDK-8296889: Race condition when cancelling a request
• e72b0ac: 8296429: Remove os::supports_sse
• 813b223: 8296926: Sort include lines of files in the include/ directory
• 8cdcec4: 8296774: Removed default MEMFLAGS value from CHeapBitMap
• c3b285a: 8296916: RISC-V: Move some small macro-assembler functions to header file
• 720c3d0: 8296932: G1: Remove unused G1RootClosures::weak_oops
• 196d021: 8297020: Rename GrowableArray::on_stack
• 5f51dff: 8296776: Stop using mtNone as marker for CHeap allocations in GrowableArray
• 499406c: 8285488: Improve DocFinder
• 97ab2c3: 8296953: Fix a typo in exception documentation
• ... and 16 more: https://git.openjdk.org/jdk/compare/c49e48417d8e58dc34455cb5b503a1ba83a710aa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tobiasholenstein Pushed as commit 4946737.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.