Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8297047: IGV: graphContent not set when opening a new tab #11168

Closed

Conversation

tobiasholenstein
Copy link
Contributor

@tobiasholenstein tobiasholenstein commented Nov 15, 2022

Open any graph in IGV. The graph will be opened in a new tab as expected. But the tab has the name "graph" instead of the actual graph name. Further, the "Bytecode" and "Control Flow" windows are not updated with the current graph.

The reason was that graphContent was not set when opening a new EditorTopComponent.

Before:
graph_not_updated

Now the title of tab and the "Control Flow" is updated:
graph_updated


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297047: IGV: graphContent not set when opening a new tab

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11168/head:pull/11168
$ git checkout pull/11168

Update a local copy of the PR:
$ git checkout pull/11168
$ git pull https://git.openjdk.org/jdk pull/11168/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11168

View PR using the GUI difftool:
$ git pr show -t 11168

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11168.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 15, 2022

👋 Welcome back tholenstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 15, 2022

@tobiasholenstein The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Nov 15, 2022
@tobiasholenstein tobiasholenstein marked this pull request as ready for review November 15, 2022 14:44
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 15, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 15, 2022

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk
Copy link

openjdk bot commented Nov 15, 2022

@tobiasholenstein This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297047: IGV: graphContent not set when opening a new tab

Reviewed-by: chagedorn, rcastanedalo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 7357a1a: 8296889: Race condition when cancelling a request
  • 87530e6: 8296913: Correct enable preview idiom in JdbLastErrorTest.java
  • fafe682: 8295861: get rid of list argument in debug agent's removeNode() API
  • 216c6f6: 8294881: test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003/TestDescription.java fails
  • 6aef3a4: 8262435: Clarify the behavior of a few inherited ZipInputStream methods
  • c042b8e: 8294731: Improve multiplicative inverse for secp256r1 implementation
  • d3051a7: 8296736: Some PKCS9Attribute can be created but cannot be encoded
  • decb1b7: 8286800: Assert in PhaseIdealLoop::dump_real_LCA is too strong

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 15, 2022
Copy link
Contributor

@robcasloz robcasloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tobiasholenstein
Copy link
Contributor Author

Thanks @chhagedorn and @robcasloz for the reviews!

/integrate

@openjdk
Copy link

openjdk bot commented Nov 16, 2022

Going to push as commit 4946737.
Since your change was applied there have been 26 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 16, 2022
@openjdk openjdk bot closed this Nov 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 16, 2022
@openjdk
Copy link

openjdk bot commented Nov 16, 2022

@tobiasholenstein Pushed as commit 4946737.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants