Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297385: Remove duplicated null typos in javadoc #11169

Closed
wants to merge 2 commits into from

Conversation

dongxuwang
Copy link
Contributor

@dongxuwang dongxuwang commented Nov 15, 2022


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

  • Yi Yang (@kelthuzadx - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11169/head:pull/11169
$ git checkout pull/11169

Update a local copy of the PR:
$ git checkout pull/11169
$ git pull https://git.openjdk.org/jdk pull/11169/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11169

View PR using the GUI difftool:
$ git pr show -t 11169

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11169.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Nov 15, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 15, 2022

Hi @dongxuwang, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user dongxuwang" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Nov 15, 2022

⚠️ @dongxuwang a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master c49e48417d8e58dc34455cb5b503a1ba83a710aa
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk
Copy link

openjdk bot commented Nov 15, 2022

@dongxuwang The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 15, 2022
@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Nov 18, 2022
@y1yang0
Copy link
Member

y1yang0 commented Nov 21, 2022

good catch, do you need a JBS issue for this?

@dongxuwang
Copy link
Contributor Author

good catch, do you need a JBS issue for this?

Thank you if you can help with that.

@y1yang0
Copy link
Member

y1yang0 commented Nov 22, 2022

good catch, do you need a JBS issue for this?

Thank you if you can help with that.

I filed https://bugs.openjdk.org/browse/JDK-8297385 for this, you can change your PR title and commit message to 8297385: Remove duplicated null typo in javadoc, OpenJDK robot will guide you remaining processes.

@dongxuwang dongxuwang changed the title Minor remove duplicate null typo in javadoc 8297385: Remove duplicated null typos in javadoc Nov 22, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 22, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2022

Webrevs

@dongxuwang
Copy link
Contributor Author

good catch, do you need a JBS issue for this?

Thank you if you can help with that.

I filed https://bugs.openjdk.org/browse/JDK-8297385 for this, you can change your PR title and commit message to 8297385: Remove duplicated null typo in javadoc, OpenJDK robot will guide you remaining processes.

Thank you, can you also help review

@RogerRiggs
Copy link
Contributor

The source of this PR is the "master" branch of your fork. Note the Comment from the bot at the top.
The conventional usage is to create a branch specific to the change you are making and create the PR from that.
You will run into trouble with git due to any commits in the master branch other than are pulled from the mainline.
You can create the new branch from your current master and then reset the HEAD of the master back to match the mainline head.

Copy link
Member

@y1yang0 y1yang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I'm not a Reviewer, you still need an approval from Reviewer.

@dongxuwang
Copy link
Contributor Author

This looks good, but I'm not a Reviewer, you still need an approval from Reviewer.

Thanks

@dongxuwang
Copy link
Contributor Author

Use #11311 instead, close this pr.

@dongxuwang dongxuwang closed this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review
3 participants