JDK-8296969: C1: PrintC1Statistics is broken after JDK-8292878

[caojoshua]

Issue is coming from https://bugs.openjdk.org/browse/JDK-8292878. This PR adds the rscratch1 argument to the affected incrementl call.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296969: C1: PrintC1Statistics is broken after JDK-8292878

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer) ⚠️ Review applies to 7a2c075b
• Vladimir Kozlov (@vnkozlov - Reviewer)
• Xin Liu (@navyxliu - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11170/head:pull/11170
$ git checkout pull/11170

Update a local copy of the PR:
$ git checkout pull/11170
$ git pull https://git.openjdk.org/jdk pull/11170/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11170

View PR using the GUI difftool:
$ git pr show -t 11170

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11170.diff

[bridgekeeper]

👋 Welcome back caojoshua! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@caojoshua The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (da9b98c5)
• 00: Full (7a2c075b)

[chhagedorn]

Looks good! I suggest to additionally add a hello world test with that flag to do some sanity testing.

[openjdk]

@caojoshua This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296969: C1: PrintC1Statistics is broken after JDK-8292878

Reviewed-by: chagedorn, kvn, xliu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• 7357a1a: 8296889: Race condition when cancelling a request
• 87530e6: 8296913: Correct enable preview idiom in JdbLastErrorTest.java
• fafe682: 8295861: get rid of list argument in debug agent's removeNode() API
• 216c6f6: 8294881: test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003/TestDescription.java fails
• 6aef3a4: 8262435: Clarify the behavior of a few inherited ZipInputStream methods
• c042b8e: 8294731: Improve multiplicative inverse for secp256r1 implementation
• d3051a7: 8296736: Some PKCS9Attribute can be created but cannot be encoded
• decb1b7: 8286800: Assert in PhaseIdealLoop::dump_real_LCA is too strong
• c49e484: 8294739: jdk/jshell/ToolShiftTabTest.java timed out
• a45c9af: 8295814: jdk/jshell/CommandCompletionTest.java fails with "lists don't have the same size expected [2] but found [1]"
• ... and 7 more: https://git.openjdk.org/jdk/compare/93d6b1f3e839a434492821ae516786c7cd4b9dc8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@chhagedorn, @vnkozlov, @navyxliu) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[caojoshua]

Looks good! I suggest to additionally add a hello world test with that flag to do some sanity testing.

Thanks. I added a basic test.

[vnkozlov]

Good.

[navyxliu]

LGTM. I am not a reviewer.

[caojoshua]

/integrate

[openjdk]

@caojoshua
Your change (at version da9b98c) is now ready to be sponsored by a Committer.

[navyxliu]

/sponsor

[openjdk]

Going to push as commit 0cbf084.
Since your change was applied there have been 18 commits pushed to the master branch:

• f662a06: 8296970: Remove sysThreadAvailableStackWithSlack from hotspot-symbols
• 7357a1a: 8296889: Race condition when cancelling a request
• 87530e6: 8296913: Correct enable preview idiom in JdbLastErrorTest.java
• fafe682: 8295861: get rid of list argument in debug agent's removeNode() API
• 216c6f6: 8294881: test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003/TestDescription.java fails
• 6aef3a4: 8262435: Clarify the behavior of a few inherited ZipInputStream methods
• c042b8e: 8294731: Improve multiplicative inverse for secp256r1 implementation
• d3051a7: 8296736: Some PKCS9Attribute can be created but cannot be encoded
• decb1b7: 8286800: Assert in PhaseIdealLoop::dump_real_LCA is too strong
• c49e484: 8294739: jdk/jshell/ToolShiftTabTest.java timed out
• ... and 8 more: https://git.openjdk.org/jdk/compare/93d6b1f3e839a434492821ae516786c7cd4b9dc8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@navyxliu @caojoshua Pushed as commit 0cbf084.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.