8282404: DrawStringWithInfiniteXform.java failed with "RuntimeException: drawString with InfiniteXform transform takes long time"#11179
Conversation
|
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
openjdk
bot
changed the title
Webrevs
|
| done = true; | ||
| timer.cancel(); | ||
| } | ||
| System.out.println("Test passed"); |
There was a problem hiding this comment.
It seems timer.cancel() says "Terminates this timer, discarding any currently scheduled tasks." so it might disregard the "done" check been done in ScheduleTask resulting in false positive...
Should we do Thread.yield() instead?
Also, this test has many coding violations like l70, l79 where no space between operators,variables...
There was a problem hiding this comment.
It seems timer.cancel() says "Terminates this timer, discarding any currently scheduled tasks."
Yes, that's the intention.
so it might disregard the "done" check been done in ScheduleTask resulting in false positive...
If we reach timer.cancel() before the timer fires off the task we don't need the task
canceling it means the test can exit immediately - not wait 20 or 30 seconds.
If it does fire because cancel is too slow, it will see "done==true"
So perhaps I'm not following your point ?
Should we do Thread.yield() instead?
No.
I'll tidy it up a bit more.
There was a problem hiding this comment.
OK. So, it means ScheduleTask should ideally never be executed if drawString with infinite transform takes lesser time < 30s, which is desirable and test can exit.
|
@prrace This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 60 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
| System.out.flush(); | ||
| float[] vals = new float[6]; | ||
| for (int i=0;i<6;i++) vals[i]=Float.POSITIVE_INFINITY; | ||
| for (int i=0; i<6; i++) { |
There was a problem hiding this comment.
We can add proper indentation for operators before push, since we are updating at other places.
There was a problem hiding this comment.
Nit
| synchronized(DrawStringWithInfiniteXform.class) { | |
| synchronized (DrawStringWithInfiniteXform.class) { |
|
/integrate |
|
Going to push as commit a53be20.
Your commit was automatically rebased without conflicts. |
openjdk
bot
removed
ready
4 participants
This test is not problem listed and has failed only once since (SFAIK) it was last updated a year ago so
this is just another small attempt to remove instability by increasing timeout, being really insistent about
making sure the "done=true" is propagated and adding some extra timing logging to help analyse any failures
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11179/head:pull/11179$ git checkout pull/11179Update a local copy of the PR:
$ git checkout pull/11179$ git pull https://git.openjdk.org/jdk pull/11179/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11179View PR using the GUI difftool:
$ git pr show -t 11179Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11179.diff