8282404: DrawStringWithInfiniteXform.java failed with "RuntimeException: drawString with InfiniteXform transform takes long time" #11179

prrace · 2022-11-16T03:44:24Z

This test is not problem listed and has failed only once since (SFAIK) it was last updated a year ago so
this is just another small attempt to remove instability by increasing timeout, being really insistent about
making sure the "done=true" is propagated and adding some extra timing logging to help analyse any failures

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8282404: DrawStringWithInfiniteXform.java failed with "RuntimeException: drawString with InfiniteXform transform takes long time"

Reviewers

Prasanta Sadhukhan (@prsadhuk - Reviewer) ⚠️ Review applies to 7becd787
Jayathirth D V (@jayathirthrao - Reviewer) ⚠️ Review applies to 7becd787

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11179/head:pull/11179
$ git checkout pull/11179

Update a local copy of the PR:
$ git checkout pull/11179
$ git pull https://git.openjdk.org/jdk pull/11179/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11179

View PR using the GUI difftool:
$ git pr show -t 11179

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11179.diff

bridgekeeper · 2022-11-16T03:46:16Z

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-11-16T03:49:46Z

@prrace The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-11-16T03:53:01Z

Webrevs

prsadhuk · 2022-11-16T04:23:37Z

test/jdk/java/awt/FontClass/DrawStringWithInfiniteXform.java

+        synchronized (DrawStringWithInfiniteXform.class) {
+            done = true;
+            timer.cancel();
+        }
        System.out.println("Test passed");


It seems timer.cancel() says "Terminates this timer, discarding any currently scheduled tasks." so it might disregard the "done" check been done in ScheduleTask resulting in false positive...
Should we do Thread.yield() instead?

Also, this test has many coding violations like l70, l79 where no space between operators,variables...

It seems timer.cancel() says "Terminates this timer, discarding any currently scheduled tasks."

Yes, that's the intention.

so it might disregard the "done" check been done in ScheduleTask resulting in false positive...

If we reach timer.cancel() before the timer fires off the task we don't need the task
canceling it means the test can exit immediately - not wait 20 or 30 seconds.

If it does fire because cancel is too slow, it will see "done==true"

So perhaps I'm not following your point ?

Should we do Thread.yield() instead?

No.

I'll tidy it up a bit more.

OK. So, it means ScheduleTask should ideally never be executed if drawString with infinite transform takes lesser time < 30s, which is desirable and test can exit.

openjdk · 2022-11-17T03:19:39Z

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282404: DrawStringWithInfiniteXform.java failed with "RuntimeException: drawString with InfiniteXform transform takes long time"

Reviewed-by: psadhukhan, jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

66228f7: 8297074: Use enhanced-for cycle instead of Enumeration in javax.crypto
819af69: 8249693: java/nio/channels/FileChannel/FileExtensionAndMap.java uses @ignore w/o bug id
9c432a0: 8297165: Update Pandoc to version 2.19.2 for Oracle builds
8b140e2: 8297152: Add a @sealedGraph tag to ZoneId
992f209: 8287180: Update IANA Language Subtag Registry to Version 2022-08-08
a768fed: 8297184: Test runtime/ErrorHandling/TestSigInfoInHsErrFile.java is failing
134acab: 8297149: REDO JDK-8296889: Race condition when cancelling a request
4120db1: 8297007: IGV: Link/Unlink node selection of open tabs
38eb80d: 8296975: RISC-V: Enable UseRVA20U64 profile by default
b6aff54: 8297201: Obsolete AliasLevel flag
... and 50 more: https://git.openjdk.org/jdk/compare/bd3acbea8c4ac0a9d3827a59bd736f0528b1b12b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

jayathirthrao · 2022-11-17T07:01:40Z

test/jdk/java/awt/FontClass/DrawStringWithInfiniteXform.java

        float[] vals = new float[6];
-        for (int i=0;i<6;i++) vals[i]=Float.POSITIVE_INFINITY;
+        for (int i=0; i<6; i++) {


We can add proper indentation for operators before push, since we are updating at other places.

turbanoff · 2022-11-17T20:22:14Z

test/jdk/java/awt/FontClass/DrawStringWithInfiniteXform.java

-                RuntimeException("drawString with InfiniteXform transform takes long time");
+            System.out.println("Task running at " + System.currentTimeMillis());
+            System.out.flush();
+            synchronized(DrawStringWithInfiniteXform.class) {


Nit

Suggested change

synchronized(DrawStringWithInfiniteXform.class) {

synchronized (DrawStringWithInfiniteXform.class) {

prrace · 2022-11-17T20:32:46Z

/integrate

openjdk · 2022-11-17T20:33:57Z

Going to push as commit a53be20.
Since your change was applied there have been 60 commits pushed to the master branch:

66228f7: 8297074: Use enhanced-for cycle instead of Enumeration in javax.crypto
819af69: 8249693: java/nio/channels/FileChannel/FileExtensionAndMap.java uses @ignore w/o bug id
9c432a0: 8297165: Update Pandoc to version 2.19.2 for Oracle builds
8b140e2: 8297152: Add a @sealedGraph tag to ZoneId
992f209: 8287180: Update IANA Language Subtag Registry to Version 2022-08-08
a768fed: 8297184: Test runtime/ErrorHandling/TestSigInfoInHsErrFile.java is failing
134acab: 8297149: REDO JDK-8296889: Race condition when cancelling a request
4120db1: 8297007: IGV: Link/Unlink node selection of open tabs
38eb80d: 8296975: RISC-V: Enable UseRVA20U64 profile by default
b6aff54: 8297201: Obsolete AliasLevel flag
... and 50 more: https://git.openjdk.org/jdk/compare/bd3acbea8c4ac0a9d3827a59bd736f0528b1b12b...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-11-17T20:34:18Z

@prrace Pushed as commit a53be20.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8282404

766dcc3

openjdk bot changed the title ~~8282404~~ 8282404: DrawStringWithInfiniteXform.java failed with "RuntimeException: drawString with InfiniteXform transform takes long time" Nov 16, 2022

openjdk bot added the rfr Pull request is ready for review label Nov 16, 2022

openjdk bot added the client client-libs-dev@openjdk.org label Nov 16, 2022

prsadhuk reviewed Nov 16, 2022

View reviewed changes

8282404

7becd78

prsadhuk approved these changes Nov 17, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 17, 2022

jayathirthrao reviewed Nov 17, 2022

View reviewed changes

jayathirthrao approved these changes Nov 17, 2022

View reviewed changes

turbanoff reviewed Nov 17, 2022

View reviewed changes

8282404

3acdd9a

openjdk bot added the integrated Pull request has been integrated label Nov 17, 2022

openjdk bot closed this Nov 17, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 17, 2022

8282404: DrawStringWithInfiniteXform.java failed with "RuntimeException: drawString with InfiniteXform transform takes long time" #11179

8282404: DrawStringWithInfiniteXform.java failed with "RuntimeException: drawString with InfiniteXform transform takes long time" #11179

prrace commented Nov 16, 2022 •

edited by openjdk bot

bridgekeeper bot commented Nov 16, 2022

openjdk bot commented Nov 16, 2022

mlbridge bot commented Nov 16, 2022 •

edited

prsadhuk Nov 16, 2022

prrace Nov 16, 2022

prsadhuk Nov 17, 2022

openjdk bot commented Nov 17, 2022 •

edited

jayathirthrao Nov 17, 2022 •

edited

turbanoff Nov 17, 2022

prrace commented Nov 17, 2022

openjdk bot commented Nov 17, 2022

openjdk bot commented Nov 17, 2022

	synchronized(DrawStringWithInfiniteXform.class) {
	synchronized (DrawStringWithInfiniteXform.class) {

8282404: DrawStringWithInfiniteXform.java failed with "RuntimeException: drawString with InfiniteXform transform takes long time" #11179

8282404: DrawStringWithInfiniteXform.java failed with "RuntimeException: drawString with InfiniteXform transform takes long time" #11179

Conversation

prrace commented Nov 16, 2022 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Nov 16, 2022

openjdk bot commented Nov 16, 2022

mlbridge bot commented Nov 16, 2022 • edited

Webrevs

prsadhuk Nov 16, 2022

Choose a reason for hiding this comment

prrace Nov 16, 2022

Choose a reason for hiding this comment

prsadhuk Nov 17, 2022

Choose a reason for hiding this comment

openjdk bot commented Nov 17, 2022 • edited

jayathirthrao Nov 17, 2022 • edited

Choose a reason for hiding this comment

turbanoff Nov 17, 2022

Choose a reason for hiding this comment

prrace commented Nov 17, 2022

openjdk bot commented Nov 17, 2022

openjdk bot commented Nov 17, 2022

prrace commented Nov 16, 2022 •

edited by openjdk bot

mlbridge bot commented Nov 16, 2022 •

edited

openjdk bot commented Nov 17, 2022 •

edited

jayathirthrao Nov 17, 2022 •

edited