Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297150: Add a @sealedGraph tag to Reference #11191

Closed
wants to merge 1 commit into from

Conversation

minborg
Copy link
Contributor

@minborg minborg commented Nov 16, 2022

This PR proposes to opt in for graphic rendering of the sealed hierarchy of the Reference class.

Rendering capability was added via https://bugs.openjdk.org/browse/JDK-8295653

Here is how it would look like:

Reference_SH


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11191/head:pull/11191
$ git checkout pull/11191

Update a local copy of the PR:
$ git checkout pull/11191
$ git pull https://git.openjdk.org/jdk pull/11191/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11191

View PR using the GUI difftool:
$ git pr show -t 11191

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11191.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 16, 2022

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 16, 2022
@openjdk
Copy link

openjdk bot commented Nov 16, 2022

@minborg The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 16, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 16, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 16, 2022

@minborg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297150: Add a @sealedGraph tag to Reference

Reviewed-by: darcy, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 157 new commits pushed to the master branch:

  • 8effaa8: 8223783: sun/net/www/http/HttpClient/MultiThreadTest.java sometimes detect threads+1 connections
  • ab1f9ff: 8051627: Invariants about java.net.URI resolve and relativize are wrong
  • df6cf1e: 8296886: Fix various include sort order issues
  • 5e196b4: 8297476: Increase InlineSmallCode default from 1000 to 2500 for RISC-V
  • 070a84c: 8297192: Warning generating API docs for javax.management.MBeanServer: overridden methods do not document exception type
  • 3c4d520: 8296671: [JFR] jdk.ContainerConfiguration event should include host total memory
  • 8b73970: 8296208: AArch64: Enable SHA512 intrinsic by default on supported hardware
  • f4cf758: 8297491: Loom: Stack chunks allocation code uses TLABs even when TLABs are disabled
  • 5e5b774: 8296768: Use different explicit claim marks for CLDs in Parallel and Serial GC
  • 9c77e41: 8297445: PPC64: Represent Registers as values
  • ... and 147 more: https://git.openjdk.org/jdk/compare/196d0210df740fe26ca674973519a30b634a6b3a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jddarcy, @AlanBateman) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 16, 2022
@minborg
Copy link
Contributor Author

minborg commented Nov 17, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 17, 2022
@openjdk
Copy link

openjdk bot commented Nov 17, 2022

@minborg
Your change (at version 541567e) is now ready to be sponsored by a Committer.

@AlanBateman
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 24, 2022

Going to push as commit 390e69a.
Since your change was applied there have been 157 commits pushed to the master branch:

  • 8effaa8: 8223783: sun/net/www/http/HttpClient/MultiThreadTest.java sometimes detect threads+1 connections
  • ab1f9ff: 8051627: Invariants about java.net.URI resolve and relativize are wrong
  • df6cf1e: 8296886: Fix various include sort order issues
  • 5e196b4: 8297476: Increase InlineSmallCode default from 1000 to 2500 for RISC-V
  • 070a84c: 8297192: Warning generating API docs for javax.management.MBeanServer: overridden methods do not document exception type
  • 3c4d520: 8296671: [JFR] jdk.ContainerConfiguration event should include host total memory
  • 8b73970: 8296208: AArch64: Enable SHA512 intrinsic by default on supported hardware
  • f4cf758: 8297491: Loom: Stack chunks allocation code uses TLABs even when TLABs are disabled
  • 5e5b774: 8296768: Use different explicit claim marks for CLDs in Parallel and Serial GC
  • 9c77e41: 8297445: PPC64: Represent Registers as values
  • ... and 147 more: https://git.openjdk.org/jdk/compare/196d0210df740fe26ca674973519a30b634a6b3a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 24, 2022
@openjdk openjdk bot closed this Nov 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 24, 2022
@openjdk
Copy link

openjdk bot commented Nov 24, 2022

@AlanBateman @minborg Pushed as commit 390e69a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants