Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296463: Memory leak in JVM_StartThread with the integration of Virtual threads #11198

Closed
wants to merge 1 commit into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Nov 16, 2022

Please review this simple fix that removes a memory leak. The _extentLocalCache OopHandle was not being released when a JavaThread was destroyed.

Testing:

  • manual leak checking with NMT
  • tier1 (sanity)
    Thanks.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296463: Memory leak in JVM_StartThread with the integration of Virtual threads

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11198/head:pull/11198
$ git checkout pull/11198

Update a local copy of the PR:
$ git checkout pull/11198
$ git pull https://git.openjdk.org/jdk pull/11198/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11198

View PR using the GUI difftool:
$ git pr show -t 11198

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11198.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 16, 2022

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 16, 2022
@openjdk
Copy link

openjdk bot commented Nov 16, 2022

@dholmes-ora The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Nov 16, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 16, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 17, 2022

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296463: Memory leak in JVM_StartThread with the integration of Virtual threads

Reviewed-by: alanb, coleenp, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • 373e52c: 8296785: Use realloc for CHeap-allocated BitMaps
  • a53be20: 8282404: DrawStringWithInfiniteXform.java failed with "RuntimeException: drawString with InfiniteXform transform takes long time"
  • 66228f7: 8297074: Use enhanced-for cycle instead of Enumeration in javax.crypto
  • 819af69: 8249693: java/nio/channels/FileChannel/FileExtensionAndMap.java uses @ignore w/o bug id
  • 9c432a0: 8297165: Update Pandoc to version 2.19.2 for Oracle builds
  • 8b140e2: 8297152: Add a @sealedGraph tag to ZoneId
  • 992f209: 8287180: Update IANA Language Subtag Registry to Version 2022-08-08
  • a768fed: 8297184: Test runtime/ErrorHandling/TestSigInfoInHsErrFile.java is failing
  • 134acab: 8297149: REDO JDK-8296889: Race condition when cancelling a request
  • 4120db1: 8297007: IGV: Link/Unlink node selection of open tabs
  • ... and 22 more: https://git.openjdk.org/jdk/compare/95c390ec75eec31cdf613c8bb236e43aa65a1bb5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 17, 2022
@dholmes-ora
Copy link
Member Author

Thanks @AlanBateman

@cowwoc
Copy link

cowwoc commented Nov 17, 2022

@dholmes-ora I have two questions about this fix:

  1. Will it fix a leak in both platform and virtual threads? Or only virtual threads?
  2. I assume you tested for leaks under JDK 19? I was under the impression that the ExtentLocal functionality was not part of this release which is why I'm surprised to see it mentioned in the fix.

Thank you.

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. Sigh... more work for the ServiceThread...

@dholmes-ora
Copy link
Member Author

Thanks @coleenp and @dcubed-ojdk !

/integrate

@openjdk
Copy link

openjdk bot commented Nov 18, 2022

Going to push as commit 7b3984c.
Since your change was applied there have been 32 commits pushed to the master branch:

  • 373e52c: 8296785: Use realloc for CHeap-allocated BitMaps
  • a53be20: 8282404: DrawStringWithInfiniteXform.java failed with "RuntimeException: drawString with InfiniteXform transform takes long time"
  • 66228f7: 8297074: Use enhanced-for cycle instead of Enumeration in javax.crypto
  • 819af69: 8249693: java/nio/channels/FileChannel/FileExtensionAndMap.java uses @ignore w/o bug id
  • 9c432a0: 8297165: Update Pandoc to version 2.19.2 for Oracle builds
  • 8b140e2: 8297152: Add a @sealedGraph tag to ZoneId
  • 992f209: 8287180: Update IANA Language Subtag Registry to Version 2022-08-08
  • a768fed: 8297184: Test runtime/ErrorHandling/TestSigInfoInHsErrFile.java is failing
  • 134acab: 8297149: REDO JDK-8296889: Race condition when cancelling a request
  • 4120db1: 8297007: IGV: Link/Unlink node selection of open tabs
  • ... and 22 more: https://git.openjdk.org/jdk/compare/95c390ec75eec31cdf613c8bb236e43aa65a1bb5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 18, 2022
@openjdk openjdk bot closed this Nov 18, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 18, 2022
@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@dholmes-ora Pushed as commit 7b3984c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@AlanBateman
Copy link
Contributor

  1. Will it fix a leak in both platform and virtual threads? Or only virtual threads?
  2. I assume you tested for leaks under JDK 19? I was under the impression that the ExtentLocal functionality was not part of this release which is why I'm surprised to see it mentioned in the fix.

This issue is a leak when a platform thread terminates. It's a complicated story but essentially the infrastructure for extent locals (since renamed to Scoped Values, see JEP 429) went into JDK 19 as part of the implementation of JEP 425. So yes, a feature for maybe JDK 20 is causing a leak in JDK 19.

@cowwoc
Copy link

cowwoc commented Nov 18, 2022

Got it. Thanks for the clarification Alan.

@dholmes-ora dholmes-ora deleted the 8296463-oophandle branch June 27, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
5 participants