Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256046: Shenandoah: Mix-in NULL_PTR in non-strong ShLRBNode's type #1120

Closed
wants to merge 3 commits into from

Conversation

rkennke
Copy link
Contributor

@rkennke rkennke commented Nov 9, 2020

Testing found this problem (very rare/hard to reproduce):

# Internal Error (d:/a/jdk/jdk/jdk/src/hotspot/cpu/x86/macroAssembler_x86.cpp:880), pid=6160, tid=5828
# fatal error: DEBUG MESSAGE: unexpected null in intrinsic

I believe this may be caused by non-strong LRB reporting a non-NULL type by passing-through its input's type, even though it may actually return NULL on non-NULL inputs. If this serves as input to an intrinsic, it may lead to elimination of surrounding null-check, and thus end up passing a NULL to the intrinsic even thought it should not.

Testing:

  • hotspot_gc_shenandoah
  • tier1+Shenandoah
  • tier2+Shenandoah

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) (3/9 running) (1/9 failed)

Failed test task

Issue

  • JDK-8256046: Shenandoah: Mix-in NULL_PTR in non-strong ShLRBNode's type

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1120/head:pull/1120
$ git checkout pull/1120

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 9, 2020

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 9, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 9, 2020

@rkennke The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc shenandoah labels Nov 9, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 9, 2020

@rkennke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256046: Shenandoah: Mix-in NULL_PTR in non-strong ShLRBNode's type

Reviewed-by: roland, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • a1d4b9f: 8256009: Remove src/hotspot/share/adlc/Test/i486.ad
  • 3455fa9: 8256050: JVM crashes with -XX:+PrintDeoptimizationDetails
  • e6df13e: 8256054: C2: Floating-point min/max operations on vectors intermittently produce wrong results for NaN values
  • 52805f5: 8256048: Incomplete gitignore setting for netbeans project
  • 9d07259: 8255598: [PPC64] assert(Universe::heap()->is_in(result)) failed: object not in heap
  • e281b13: 8255011: [TESTBUG] compiler/codecache/stress/UnexpectedDeoptimizationAllTest.java timed out
  • c601849: 8256038: G1: Improve comment about mark word handling of displaced mark words
  • a38dd53: 8256040: Shenandoah: Allow NULL referent in ShenandoahReferenceProcessor::should_discover()
  • 01567b5: 8256036: Shenandoah: MethodHandles adapters section overflows after JDK-8255762
  • 4bc065c: 8255782: Turn UseTLAB and ResizeTLAB from product_pd to product, defaulting to "true"
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/d99e1f6c296c23b8714fc94fe4f3c7bece000f9c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 9, 2020
@rkennke rkennke changed the title 8256046: Shenandoah: fatal error: DEBUG MESSAGE: unexpected null in intrinsic 8256046: Shenandoah: Mix-in NULL_PTR in non-strong ShLRBNode's type Nov 9, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 9, 2020

Webrevs

@openjdk openjdk bot added ready and removed ready labels Nov 9, 2020
Copy link
Contributor

@shipilev shipilev left a comment

Thanks. Looks fine to me.

@rkennke
Copy link
Contributor Author

@rkennke rkennke commented Nov 10, 2020

/integrate

@openjdk openjdk bot closed this Nov 10, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 10, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 10, 2020

@rkennke Since your change was applied there have been 18 commits pushed to the master branch:

  • a1d4b9f: 8256009: Remove src/hotspot/share/adlc/Test/i486.ad
  • 3455fa9: 8256050: JVM crashes with -XX:+PrintDeoptimizationDetails
  • e6df13e: 8256054: C2: Floating-point min/max operations on vectors intermittently produce wrong results for NaN values
  • 52805f5: 8256048: Incomplete gitignore setting for netbeans project
  • 9d07259: 8255598: [PPC64] assert(Universe::heap()->is_in(result)) failed: object not in heap
  • e281b13: 8255011: [TESTBUG] compiler/codecache/stress/UnexpectedDeoptimizationAllTest.java timed out
  • c601849: 8256038: G1: Improve comment about mark word handling of displaced mark words
  • a38dd53: 8256040: Shenandoah: Allow NULL referent in ShenandoahReferenceProcessor::should_discover()
  • 01567b5: 8256036: Shenandoah: MethodHandles adapters section overflows after JDK-8255762
  • 4bc065c: 8255782: Turn UseTLAB and ResizeTLAB from product_pd to product, defaulting to "true"
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/d99e1f6c296c23b8714fc94fe4f3c7bece000f9c...master

Your commit was automatically rebased without conflicts.

Pushed as commit 97d6e4a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated shenandoah
3 participants