8191406: [hidpi] sun/java2d/SunGraphics2D/DrawImageBilinear.java test fails #11201

jayathirthrao · 2022-11-17T08:20:54Z

This test was failing because of timing or color difference issues.
Updated test to:

Use EDT for UI drawing instead of manual synchronisation
Use Robot.waitForIdle before screen capture
Increase color tolerance delta from 1 to 5
Use undecorated frame and explicitly set background color and move the frame to top
Cleanup to remove not needed flags and java options

After these changes test passes on all platforms in CI except Linux. For Linux it looks like product issue so i have raised : https://bugs.openjdk.org/browse/JDK-8297175

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8191406: [hidpi] sun/java2d/SunGraphics2D/DrawImageBilinear.java test fails

Reviewers

Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11201/head:pull/11201
$ git checkout pull/11201

Update a local copy of the PR:
$ git checkout pull/11201
$ git pull https://git.openjdk.org/jdk pull/11201/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11201

View PR using the GUI difftool:
$ git pr show -t 11201

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11201.diff

bridgekeeper · 2022-11-17T08:21:43Z

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-11-17T08:25:30Z

@jayathirthrao The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-11-17T08:28:30Z

Webrevs

mrserb · 2022-11-17T17:43:40Z

Increase color tolerance delta from 1 to 5

I see that the tolerance is added to the test, previously it was 0. Why do we need it since we use quite simple RED color?

test/jdk/sun/java2d/SunGraphics2D/DrawImageBilinear.java

jayathirthrao · 2022-11-18T06:44:57Z

Increase color tolerance delta from 1 to 5

I see that the tolerance is added to the test, previously it was 0. Why do we need it since we use quite simple RED color?

We have a tolerance of 1 for red color. We dont throw exception when red channel is 254.
But i think we dont need extra tolerance and it was added because of local machine reporting differences.
I have removed the extra tolerance and see that test passes in CI.

mlbridge · 2022-11-18T23:02:47Z

Mailing list message from Sebastian Luckner on client-libs-dev:

dieses script funktioniert mittlerweile hoffentlich ?berall gleich:

public static String[] av = new String[] {

"AAAA", "AAAC", "AAAT", "AAAG", "AACA", "AACC", "AACT", "AACG", "AATA", "AATC", "AATT", "AATG", "AAGA", "AAGC", "AAGT", "AAGG",
"ACAA", "ACAC", "ACAT", "ACAG", "ACCA", "ACCC", "ACCT", "ACCG", "ACTA", "ACTC", "ACTT", "ACTG", "ACGA", "ACGC", "ACGT", "ACGG",
"ATAA", "ATAC", "ATAT", "ATAG", "ATCA", "ATCC", "ATCT", "ATCG", "ATTA", "ATTC", "ATTT", "ATTG", "ATGA", "ATGC", "ATGT", "ATGG",
"AGAA", "AGAC", "AGAT", "AGAG", "AGCA", "AGCC", "AGCT", "AGCG", "AGTA", "AGTC", "AGTT", "AGTG", "AGGA", "AGGC", "AGGT", "AGGG",

"CAAA", "CAAC", "CAAT", "CAAG", "CACA", "CACC", "CACT", "CACG", "CATA", "CATC", "CATT", "CATG", "CAGA", "CAGC", "CAGT", "CAGG",
"CCAA", "CCAC", "CCAT", "CCAG", "CCCA", "CCCC", "CCCT", "CCCG", "CCTA", "CCTC", "CCTT", "CCTG", "CCGA", "CCGC", "CCGT", "CCGG",
"CTAA", "CTAC", "CTAT", "CTAG", "CTCA", "CTCC", "CTCT", "CTCG", "CTTA", "CTTC", "CTTT", "CTTG", "CTGA", "CTGC", "CTGT", "CTGG",
"CGAA", "CGAC", "CGAT", "CGAG", "CGCA", "CGCC", "CGCT", "CGCG", "CGTA", "CGTC", "CGTT", "CGTG", "CGGA", "CGGC", "CGGT", "CGGG",

"TAAA", "TAAC", "TAAT", "TAAG", "TACA", "TACC", "TACT", "TACG", "TATA", "TATC", "TATT", "TATG", "TAGA", "TAGC", "TAGT", "TAGG",
"TCAA", "TCAC", "TCAT", "TCAG", "TCCA", "TCCC", "TCCT", "TCCG", "TCTA", "TCTC", "TCTT", "TCTG", "TCGA", "TCGC", "TCGT", "TCGG",
"TTAA", "TTAC", "TTAT", "TTAG", "TTCA", "TTCC", "TTCT", "TTCG", "TTTA", "TTTC", "TTTT", "TTTG", "TTGA", "TTGC", "TTGT", "TTGG",
"TGAA", "TGAC", "TGAT", "TGAG", "TGCA", "TGCC", "TGCT", "TGCG", "TGTA", "TGTC", "TGTT", "TGTG", "TGGA", "TGGC", "TGGT", "TGGG",

"GAAA", "GAAC", "GAAT", "GAAG", "GACA", "GACC", "GACT", "GACG", "GATA", "GATC", "GATT", "GATG", "GAGA", "GAGC", "GAGT", "GAGG",
"GCAA", "GCAC", "GCAT", "GCAG", "GCCA", "GCCC", "GCCT", "GCCG", "GCTA", "GCTC", "GCTT", "GCTG", "GCGA", "GCGC", "GCGT", "GCGG",
"GTAA", "GTAC", "GTAT", "GTAG", "GTCA", "GTCC", "GTCT", "GTCG", "GTTA", "GTTC", "GTTT", "GTTG", "GTGA", "GTGC", "GTGT", "GTGG",
"GGAA", "GGAC", "GGAT", "GGAG", "GGCA", "GGCC", "GGCT", "GGCG", "GGTA", "GGTC", "GGTT", "GGTG", "GGGA", "GGGC", "GGGT", "GGGG"

};

av[2] + av[0] > av[19] + av[31]

f?r gutes wirklich ?berall gleich lang ausf?hrbares script erhalte man ab sofort genau obrige kombination von den eigenen ahnen.

das problem war:

ein

static WIDTH = 16, HEIGHT = 16

das per hand durch 16 ersetzt werden konnte.

f?r tk dna:

av[16] + av[916] + av[54] + av[96];

und av[3];

wer noch mit der eigenen dna programieren lernen will, hier der vergessenscode von fehlermeldungen:

243987524397085243987045398724375289987403942872349875239874239408724395870

3074259838749328749098325749432508790874325432790845327982439708

7290384574398523984057293087443527982398745032874943259870

9032874523749803749802349875453987243958704325907824390857

3290874532908742345987023497085308729438793908744538792

7298304239587403

8732905237498398704523974823

298730452394087

2739408745980239408723497084357980932874

23790842908743538794239087987320487294327398

032987452349872439870543298704987023249875

273908452743950859805980598059804

29087345290873290873452908734529087342590873425908734529087345290873425908734259087345290873452908734259087342590873425908734259087345290873452908734259087342590873425908734529087345290873425908734259087345290873452908734259087342590873452908734529087342590873290873

32907542930874529873045298730457934279083247908

23984075987345987739083

902873457298437872083945

239408752735279083940870879

was hier sein kann:

329087548790438732490287439495087

was wohl nicht mehr gut w#?re ist 0b0110101010101010101010101010101010101010101010101010101010101010101010!=!=!=!=!=!=!=!=!=!=!=!=!=!=!=!=!=!=!=!=!=!=!==!=!

________________________________
Von: client-libs-dev <client-libs-dev-retn at openjdk.org> im Auftrag von Jayathirth D V <jdv at openjdk.org>
Gesendet: Freitag, 18. November 2022 07:52:52
An: client-libs-dev at openjdk.org
Betreff: [EXT] Re: RFR: 8191406: [hidpi] sun/java2d/SunGraphics2D/DrawImageBilinear.java test fails [v3]

This test was failing because of timing or color difference issues.
Updated test to:

1) Use EDT for UI drawing instead of manual synchronisation
2) Use Robot.waitForIdle before screen capture
3) Increase color tolerance delta from 1 to 5
4) Use undecorated frame and explicitly set background color and move the frame to top
5) Cleanup to remove not needed flags and java options

After these changes test passes on all platforms in CI except Linux. For Linux it looks like product issue so i have raised : https://bugs.openjdk.org/browse/JDK-8297175

Jayathirth D V has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. The pull request now contains four commits:

- Remove image dump
- ProblemList only on Linux
- Add background color and tolerance
- Initial change

-------------

Changes:
- all: https://git.openjdk.org/jdk/pull/11201/files
- new: https://git.openjdk.org/jdk/pull/11201/files/ec464893..60c75ca

Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=11201&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=11201&range=01-02

Stats: 15 lines in 1 file changed: 14 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/11201.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/11201/head:pull/11201

PR: https://git.openjdk.org/jdk/pull/11201
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/client-libs-dev/attachments/20221118/1f918795/attachment-0001.htm>

jayathirthrao · 2022-11-21T10:04:51Z

I am ignoring the previous comment. Even after translating, the comment looks to be not related to current PR.
@mrserb please take a look at updated PR.

test/jdk/sun/java2d/SunGraphics2D/DrawImageBilinear.java

openjdk · 2022-11-23T01:59:56Z

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8191406: [hidpi] sun/java2d/SunGraphics2D/DrawImageBilinear.java test fails

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 132 new commits pushed to the master branch:

09f70da: 8296265: Use modern HTML in the JVMTI spec
e661c5a: 8296323: JVMTI can_support_virtual_threads not available for agents loaded into running VM
974cb83: 8297310: Remove unimplemented HeapInspection::iterate_over_heap
e174558: 8296742: Illegal X509 Extension should not be created
a6c418e: 8297168: Provide a bulk OopHandle release mechanism with the ServiceThread
4a544bb: 8297091: New langtools test jdk/javadoc/doclet/testValueTag/TestValueFormats.java fails on machines with unexpected number format
b6dddf4: 8239801: [macos] java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java fails
260e4dc: 8295011: EC point multiplication improvement for secp256r1
fb6c992: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2
ccc6e16: 8291067: macOS should use O_CLOEXEC instead of FD_CLOEXEC
... and 122 more: https://git.openjdk.org/jdk/compare/65f7de252366e30ba18a22c107fc301c0fdc9378...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

jayathirthrao · 2022-11-23T03:36:57Z

/integrate

openjdk · 2022-11-23T03:38:49Z

Going to push as commit b4bd287.
Since your change was applied there have been 134 commits pushed to the master branch:

412b436: 6201035: Document NPE for passing null insets to constructors and methods of several javax.swing.border.* classes
faf48e6: 8296329: jar validator doesn't account for minor class file version
09f70da: 8296265: Use modern HTML in the JVMTI spec
e661c5a: 8296323: JVMTI can_support_virtual_threads not available for agents loaded into running VM
974cb83: 8297310: Remove unimplemented HeapInspection::iterate_over_heap
e174558: 8296742: Illegal X509 Extension should not be created
a6c418e: 8297168: Provide a bulk OopHandle release mechanism with the ServiceThread
4a544bb: 8297091: New langtools test jdk/javadoc/doclet/testValueTag/TestValueFormats.java fails on machines with unexpected number format
b6dddf4: 8239801: [macos] java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java fails
260e4dc: 8295011: EC point multiplication improvement for secp256r1
... and 124 more: https://git.openjdk.org/jdk/compare/65f7de252366e30ba18a22c107fc301c0fdc9378...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-11-23T03:39:08Z

@jayathirthrao Pushed as commit b4bd287.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

jayathirthrao added 4 commits November 16, 2022 14:23

Initial change

90de08e

Add background color and tolerance

11127f7

ProblemList only on Linux

39f6d65

Remove image dump

60c75ca

openjdk bot added the rfr Pull request is ready for review label Nov 17, 2022

openjdk bot added the client client-libs-dev@openjdk.org label Nov 17, 2022

mrserb reviewed Nov 17, 2022

View reviewed changes

test/jdk/sun/java2d/SunGraphics2D/DrawImageBilinear.java Outdated Show resolved Hide resolved

Remove extra tolerance and background color

ec46489

mrserb reviewed Nov 22, 2022

View reviewed changes

test/jdk/sun/java2d/SunGraphics2D/DrawImageBilinear.java Outdated Show resolved Hide resolved

Exit on non creation of GUI

78eb290

mrserb approved these changes Nov 23, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 23, 2022

openjdk bot added the integrated Pull request has been integrated label Nov 23, 2022

openjdk bot closed this Nov 23, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 23, 2022

jayathirthrao deleted the JDK-8191406 branch November 23, 2022 05:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8191406: [hidpi] sun/java2d/SunGraphics2D/DrawImageBilinear.java test fails #11201

8191406: [hidpi] sun/java2d/SunGraphics2D/DrawImageBilinear.java test fails #11201

jayathirthrao commented Nov 17, 2022 •

edited by openjdk bot

Loading

bridgekeeper bot commented Nov 17, 2022

openjdk bot commented Nov 17, 2022

mlbridge bot commented Nov 17, 2022 •

edited

Loading

mrserb commented Nov 17, 2022

jayathirthrao commented Nov 18, 2022

mlbridge bot commented Nov 18, 2022

jayathirthrao commented Nov 21, 2022

openjdk bot commented Nov 23, 2022

jayathirthrao commented Nov 23, 2022

openjdk bot commented Nov 23, 2022

openjdk bot commented Nov 23, 2022

8191406: [hidpi] sun/java2d/SunGraphics2D/DrawImageBilinear.java test fails #11201

8191406: [hidpi] sun/java2d/SunGraphics2D/DrawImageBilinear.java test fails #11201

Conversation

jayathirthrao commented Nov 17, 2022 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Nov 17, 2022

openjdk bot commented Nov 17, 2022

mlbridge bot commented Nov 17, 2022 • edited Loading

Webrevs

mrserb commented Nov 17, 2022

jayathirthrao commented Nov 18, 2022

mlbridge bot commented Nov 18, 2022

jayathirthrao commented Nov 21, 2022

openjdk bot commented Nov 23, 2022

jayathirthrao commented Nov 23, 2022

openjdk bot commented Nov 23, 2022

openjdk bot commented Nov 23, 2022

jayathirthrao commented Nov 17, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Nov 17, 2022 •

edited

Loading