8296324: JVMTI GetStackTrace truncates vthread stack trace for agents loaded into running VM #11204

sspitsyn · 2022-11-17T09:12:07Z

The VirtualThread static field notifyJvmtiEvents is not set correctly in cases JVMTI agents are loaded into running VM. It is because an extra call to java_lang_VirtualThread::init_static_notify_jvmti_events() is needed.
This function is called once at the VM initialization, so this extra call is not necessary for agent loaded at startup.

Testing:
New test is added: test/hotspot/jtreg/serviceability/jvmti/vthread/VirtualStackTraceTest
This test is failed without fix and passed with it.
TBD: run all JVMTI and JDI test in mach5.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8296324: JVMTI GetStackTrace truncates vthread stack trace for agents loaded into running VM

Reviewers

Chris Plummer (@plummercj - Reviewer)
Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11204/head:pull/11204
$ git checkout pull/11204

Update a local copy of the PR:
$ git checkout pull/11204
$ git pull https://git.openjdk.org/jdk pull/11204/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11204

View PR using the GUI difftool:
$ git pr show -t 11204

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11204.diff

… loaded into running VM

bridgekeeper · 2022-11-17T09:13:01Z

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-11-17T09:15:33Z

@sspitsyn The following labels will be automatically applied to this pull request:

hotspot
serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-11-17T09:26:30Z

Webrevs

.../hotspot/jtreg/serviceability/jvmti/vthread/VirtualStackTraceTest/VirtualStackTraceTest.java

plummercj · 2022-11-17T18:37:09Z

src/hotspot/share/prims/jvmtiExport.cpp

@@ -382,7 +382,13 @@ JvmtiExport::get_jvmti_interface(JavaVM *jvm, void **penv, jint version) {
  }
  if (Continuations::enabled()) {
    // Virtual threads support. There is a performance impact when VTMS transitions are enabled.
-    java_lang_VirtualThread::set_notify_jvmti_events(true);
+    if (!java_lang_VirtualThread ::notify_jvmti_events()) {


remove extra space before ::

Thank you. Will fix it.

src/hotspot/share/prims/jvmtiExport.cpp

plummercj · 2022-11-18T19:34:19Z

src/hotspot/share/prims/jvmtiExport.cpp

+    if (JvmtiEnv::get_phase() == JVMTI_PHASE_LIVE) {
+      ThreadInVMfromNative __tiv(JavaThread::current());
+      java_lang_VirtualThread::init_static_notify_jvmti_events();
+    }
  }


Yes, this looks good now. Removing the if (!java_lang_VirtualThread ::notify_jvmti_events()) check means the init_static_notify_jvmti_events() can still be called on subsequent calls to this method. So if init_static_notify_jvmti_events() was not called the first time (due to not being in the LIVE phase), then it can still be called on subsequent calls to this method if not in the LIVE phase.

Okay. Thank you for the review, Chris,

openjdk · 2022-11-18T19:35:45Z

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296324: JVMTI GetStackTrace truncates vthread stack trace for agents loaded into running VM

Reviewed-by: cjplummer, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 379 new commits pushed to the master branch:

2c692aa: 8297088: Update LCMS to 2.14
9b4e0e8: 8297080: Remove com/sun/jdi/NashornPopFrameTest.java from the problem list
3272954: 8297083: Remove vmTestbase/nsk/jvmti/GetAllThreads/allthr001 from problem list
c4b6920: 8296910: Add EdDSA/XDH/RSASSA-PSS to KeyPairGeneratorBench.java
f34ca80: 8297245: JFR: TestRemoteDump should use RemoteRecordingStream
13158cb: 8293041: --disable-@files option doesn't work and cause an error
761a4f4: 8295788: C2 compilation hits "assert((mode == ControlAroundStripMined && use == sfpt) || !use->is_reachable_from_root()) failed: missed a node"
2f2d404: 8297129: Inflater documentation refers to 'deflate' methods
dd18d76: 8297173: usageTicks and totalTicks should be volatile to ensure that different threads get the latest ticks
2b6dbc7: 8293856: AArch64: Remove clear_inst_mark from aarch64_enc_java_dynamic_call
... and 369 more: https://git.openjdk.org/jdk/compare/c5e0464098f8f7cd9c568c7b1c3a06139453eaab...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

sspitsyn · 2022-11-18T20:04:29Z

Thank you for review, Leonid.

sspitsyn · 2022-11-18T20:50:39Z

/integrate

openjdk · 2022-11-18T20:53:13Z

Going to push as commit 035eaee.
Since your change was applied there have been 381 commits pushed to the master branch:

59a308b: 8296632: Write a test to verify the content change of TextArea sends TextEvent
11fc65f: 8023562: [TEST_BUG] java/awt/Mouse/EnterExitEvents/DragWindowTest.java failed on ubuntu 13 and mac 10.11
2c692aa: 8297088: Update LCMS to 2.14
9b4e0e8: 8297080: Remove com/sun/jdi/NashornPopFrameTest.java from the problem list
3272954: 8297083: Remove vmTestbase/nsk/jvmti/GetAllThreads/allthr001 from problem list
c4b6920: 8296910: Add EdDSA/XDH/RSASSA-PSS to KeyPairGeneratorBench.java
f34ca80: 8297245: JFR: TestRemoteDump should use RemoteRecordingStream
13158cb: 8293041: --disable-@files option doesn't work and cause an error
761a4f4: 8295788: C2 compilation hits "assert((mode == ControlAroundStripMined && use == sfpt) || !use->is_reachable_from_root()) failed: missed a node"
2f2d404: 8297129: Inflater documentation refers to 'deflate' methods
... and 371 more: https://git.openjdk.org/jdk/compare/c5e0464098f8f7cd9c568c7b1c3a06139453eaab...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-11-18T20:53:32Z

@sspitsyn Pushed as commit 035eaee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8296324: JVMTI GetStackTrace truncates vthread stack trace for agents…

bf2fa44

… loaded into running VM

openjdk bot added serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org labels Nov 17, 2022

fixed traling whitespace in jvmtiExport.cpp

b995eb4

openjdk bot added the rfr Pull request is ready for review label Nov 17, 2022

lmesnik reviewed Nov 17, 2022

View reviewed changes

.../hotspot/jtreg/serviceability/jvmti/vthread/VirtualStackTraceTest/VirtualStackTraceTest.java Show resolved Hide resolved

add @requires vm.jvmti to VirtualStackTraceTest

5a15a6d

plummercj suggested changes Nov 17, 2022

View reviewed changes

ajust condition when init_static_notify_jvmti_events() is called

a312338

plummercj reviewed Nov 18, 2022

View reviewed changes

plummercj approved these changes Nov 18, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 18, 2022

lmesnik approved these changes Nov 18, 2022

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Nov 18, 2022

openjdk bot closed this Nov 18, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 18, 2022

sspitsyn deleted the br17 branch December 15, 2022 10:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8296324: JVMTI GetStackTrace truncates vthread stack trace for agents loaded into running VM #11204

8296324: JVMTI GetStackTrace truncates vthread stack trace for agents loaded into running VM #11204

sspitsyn commented Nov 17, 2022 •

edited by openjdk bot

Loading

bridgekeeper bot commented Nov 17, 2022

openjdk bot commented Nov 17, 2022

mlbridge bot commented Nov 17, 2022 •

edited

Loading

plummercj Nov 17, 2022

sspitsyn Nov 18, 2022

plummercj Nov 18, 2022

sspitsyn Nov 18, 2022

openjdk bot commented Nov 18, 2022 •

edited

Loading

sspitsyn commented Nov 18, 2022

sspitsyn commented Nov 18, 2022

openjdk bot commented Nov 18, 2022

openjdk bot commented Nov 18, 2022

8296324: JVMTI GetStackTrace truncates vthread stack trace for agents loaded into running VM #11204

8296324: JVMTI GetStackTrace truncates vthread stack trace for agents loaded into running VM #11204

Conversation

sspitsyn commented Nov 17, 2022 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Nov 17, 2022

openjdk bot commented Nov 17, 2022

mlbridge bot commented Nov 17, 2022 • edited Loading

Webrevs

plummercj Nov 17, 2022

Choose a reason for hiding this comment

sspitsyn Nov 18, 2022

Choose a reason for hiding this comment

plummercj Nov 18, 2022

Choose a reason for hiding this comment

sspitsyn Nov 18, 2022

Choose a reason for hiding this comment

openjdk bot commented Nov 18, 2022 • edited Loading

sspitsyn commented Nov 18, 2022

sspitsyn commented Nov 18, 2022

openjdk bot commented Nov 18, 2022

openjdk bot commented Nov 18, 2022

sspitsyn commented Nov 17, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Nov 17, 2022 •

edited

Loading

openjdk bot commented Nov 18, 2022 •

edited

Loading