Skip to content

8286575: Document how properties in java.security are parsed #11208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

coffeys
Copy link
Contributor

@coffeys coffeys commented Nov 17, 2022

A doc edit to indicate that modifications of values in java.security conf file would require a JVM restart in order for such changes to be detected.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8286575: Document how properties in java.security are parsed

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11208/head:pull/11208
$ git checkout pull/11208

Update a local copy of the PR:
$ git checkout pull/11208
$ git pull https://git.openjdk.org/jdk pull/11208/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11208

View PR using the GUI difftool:
$ git pr show -t 11208

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11208.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2022

👋 Welcome back coffeys! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 17, 2022
@openjdk
Copy link

openjdk bot commented Nov 17, 2022

@coffeys The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Nov 17, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 17, 2022

Webrevs

Comment on lines 28 to 29
# Properties in this file are typically parsed only once. Any modification
# would require an application restart to reflect changes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change the second sentence to "If any of the properties are modified, applications should be restarted to ensure the changes are properly reflected."

This makes it more consistent with the words in the first sentence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. Change implemented.

Copy link
Member

@seanjmullan seanjmullan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a noreg-doc label to the issue. Looks good otherwise.

@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@coffeys This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286575: Document how properties in java.security are parsed

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

  • 5c33454: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call
  • 0800813: 8293584: CodeCache::old_nmethods_do incorrectly filters is_unloading nmethods
  • 16ab754: 8196018: java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java fails
  • 8b8d848: 8293422: DWARF emitted by Clang cannot be parsed
  • 59d8f67: 8297265: G1: Remove unnecessary null-check in RebuildCodeRootClosure::do_code_blob
  • 2fc340a: 8148041: Test java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick fails on Ubuntu with mouseReleased event after double click on title bar
  • e420661: 8297238: RISC-V: C2: Use Matcher::vector_element_basic_type when checking for vector element type in predicate
  • 891c706: 8295276: AArch64: Add backend support for half float conversion intrinsics
  • 3c09498: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java
  • 45d1807: 6312651: Compiler should only use verified interface types for optimization
  • ... and 50 more: https://git.openjdk.org/jdk/compare/171553a61194b91eeaff68198e105327484f173e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 21, 2022
@coffeys
Copy link
Contributor Author

coffeys commented Nov 21, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 21, 2022

Going to push as commit d0a7938.
Since your change was applied there have been 60 commits pushed to the master branch:

  • 5c33454: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call
  • 0800813: 8293584: CodeCache::old_nmethods_do incorrectly filters is_unloading nmethods
  • 16ab754: 8196018: java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java fails
  • 8b8d848: 8293422: DWARF emitted by Clang cannot be parsed
  • 59d8f67: 8297265: G1: Remove unnecessary null-check in RebuildCodeRootClosure::do_code_blob
  • 2fc340a: 8148041: Test java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick fails on Ubuntu with mouseReleased event after double click on title bar
  • e420661: 8297238: RISC-V: C2: Use Matcher::vector_element_basic_type when checking for vector element type in predicate
  • 891c706: 8295276: AArch64: Add backend support for half float conversion intrinsics
  • 3c09498: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java
  • 45d1807: 6312651: Compiler should only use verified interface types for optimization
  • ... and 50 more: https://git.openjdk.org/jdk/compare/171553a61194b91eeaff68198e105327484f173e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 21, 2022
@openjdk openjdk bot closed this Nov 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2022
@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@coffeys Pushed as commit d0a7938.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants