-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8286575: Document how properties in java.security are parsed #11208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back coffeys! A progress list of the required criteria for merging this PR into |
Webrevs
|
# Properties in this file are typically parsed only once. Any modification | ||
# would require an application restart to reflect changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe change the second sentence to "If any of the properties are modified, applications should be restarted to ensure the changes are properly reflected."
This makes it more consistent with the words in the first sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review. Change implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a noreg-doc label to the issue. Looks good otherwise.
@coffeys This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 60 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit d0a7938.
Your commit was automatically rebased without conflicts. |
A doc edit to indicate that modifications of values in java.security conf file would require a JVM restart in order for such changes to be detected.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11208/head:pull/11208
$ git checkout pull/11208
Update a local copy of the PR:
$ git checkout pull/11208
$ git pull https://git.openjdk.org/jdk pull/11208/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11208
View PR using the GUI difftool:
$ git pr show -t 11208
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11208.diff