Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8297209: Serial: Refactor GenCollectedHeap::full_process_roots #11210

Closed
wants to merge 2 commits into from
Closed

8297209: Serial: Refactor GenCollectedHeap::full_process_roots #11210

wants to merge 2 commits into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Nov 17, 2022 •
edited by openjdk bot

Simple change of replacing MarkingCodeBlobClosure with CodeBlobToOopClosure in the adjust-phase of Full GC.

Test: tier1-5

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297209: Serial: Refactor GenCollectedHeap::full_process_roots

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11210/head:pull/11210
$ git checkout pull/11210

Update a local copy of the PR:
$ git checkout pull/11210
$ git pull https://git.openjdk.org/jdk pull/11210/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11210

View PR using the GUI difftool:
$ git pr show -t 11210

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11210.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2022

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8297209 8297209: Serial: Refactor GenCollectedHeap::full_process_roots Nov 17, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 17, 2022
@openjdk
Copy link

openjdk bot commented Nov 17, 2022

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Nov 17, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 17, 2022 •
edited

Webrevs

tschatzl
tschatzl suggested changes Nov 25, 2022
View reviewed changes
src/hotspot/share/gc/shared/genCollectedHeap.cpp Outdated
CLDClosure* weak_cld_closure = only_strong_roots ? NULL : cld_closure;

process_roots(so, root_closure, cld_closure, weak_cld_closure, &mark_code_closure);
if (is_marking_phase) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think it is useful to explicitly create a local variable of the inverse of a parameter for its single use. That looks like the parameter is wrong.

I recommend either using is_adjust_phase directly here (potentially swapping the branches) or change the parameter of the method and the callers if you prefer to have is_marking_phase here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this change, it becomes apparent this method should be split into two, for marking/adjust phase respectively, which I plan to address in the next PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not mind doing this in this PR - it is called Refactor GenCollectedHeap::full_process_roots after all, but I do not mind.

@openjdk
Copy link

openjdk bot commented Nov 28, 2022 •
edited

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297209: Serial: Refactor GenCollectedHeap::full_process_roots

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 372 new commits pushed to the master branch:

  • 86270e3: 8269820: C2 PhaseIdealLoop::do_unroll get wrong opaque node
  • cf63f2e: 8298184: Incorrect record component type in record patterns
  • 58170f6: 8298035: Provide better descriptions for JIT compiler JFR events
  • bfcc238: 8297964: Jetty.java fails "assert(_no_handle_mark_nesting == 0) failed: allocating handle inside NoHandleMark"
  • 3e041eb: 8298248: Limit sscanf output width in cgroup file parsers
  • 4da8411: 8298108: Add a regression test for JDK-8297684
  • 80cbfab: 8298169: Remove unused methods in space.hpp
  • 221e1a4: 8286666: JEP 429: Implementation of Scoped Values (Incubator)
  • ccc69af: 8296672: Implementation of Virtual Threads (Second Preview)
  • 5a3439d: 4677581: ColorModel.getComponentSize()-wrong conditions for ArrayIndexOutOfBoundsExceptio
  • ... and 362 more: https://git.openjdk.org/jdk/compare/813b223a6bcd9f6290ee9c8840a8c69061ade48c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 28, 2022
walulyai
walulyai approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@walulyai walulyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 7, 2022

Going to push as commit 6ed3683.
Since your change was applied there have been 372 commits pushed to the master branch:

  • 86270e3: 8269820: C2 PhaseIdealLoop::do_unroll get wrong opaque node
  • cf63f2e: 8298184: Incorrect record component type in record patterns
  • 58170f6: 8298035: Provide better descriptions for JIT compiler JFR events
  • bfcc238: 8297964: Jetty.java fails "assert(_no_handle_mark_nesting == 0) failed: allocating handle inside NoHandleMark"
  • 3e041eb: 8298248: Limit sscanf output width in cgroup file parsers
  • 4da8411: 8298108: Add a regression test for JDK-8297684
  • 80cbfab: 8298169: Remove unused methods in space.hpp
  • 221e1a4: 8286666: JEP 429: Implementation of Scoped Values (Incubator)
  • ccc69af: 8296672: Implementation of Virtual Threads (Second Preview)
  • 5a3439d: 4677581: ColorModel.getComponentSize()-wrong conditions for ArrayIndexOutOfBoundsExceptio
  • ... and 362 more: https://git.openjdk.org/jdk/compare/813b223a6bcd9f6290ee9c8840a8c69061ade48c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 7, 2022
@openjdk openjdk bot closed this Dec 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 7, 2022
@openjdk
Copy link

openjdk bot commented Dec 7, 2022

@albertnetymk Pushed as commit 6ed3683.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the s1-process-roots branch December 7, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschatzl tschatzl tschatzl approved these changes

@walulyai walulyai walulyai approved these changes

Assignees
No one assigned
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
3 participants
@albertnetymk @tschatzl @walulyai